Bug 175109

Summary:

NetworkResourceLoader::setDefersLoading() may cause start() to be called multiple times

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebKit2

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, aestes, beidson, commit-queue, ggaren, kling, koivisto, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Chris Dumez 2017-08-02 19:30:35 PDT

NetworkResourceLoader::setDefersLoading() may cause start() to be called multiple times.

Comment 1 Chris Dumez 2017-08-02 19:30:52 PDT

<rdar://problem/33363169>

Comment 2 Chris Dumez 2017-08-02 19:56:16 PDT

Created attachment 317070 [details]
Patch

Comment 3 Brady Eidson 2017-08-02 20:12:27 PDT

Comment on attachment 317070 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317070&action=review

> Source/WebKit/ChangeLog:16
> +        Normally, setDefersLoading(false) returns without calling start() is m_networkLoad is not null. It

typo "...if m_networkLoad is not..."

Comment 4 Chris Dumez 2017-08-02 20:28:57 PDT

Created attachment 317078 [details]
Patch

Comment 5 WebKit Commit Bot 2017-08-02 22:57:48 PDT

Comment on attachment 317078 [details]
Patch

Clearing flags on attachment: 317078

Committed r220185: <http://trac.webkit.org/changeset/220185>

Comment 6 WebKit Commit Bot 2017-08-02 22:57:50 PDT

All reviewed patches have been landed.  Closing bug.