Bug 175107

Summary: REGRESSION(r220052): http/tests/appcache/deferred-events-delete-while-raising-timer.html is crashing.
Product: WebKit Reporter: Matt Lewis <jlewis3>
Component: New BugsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, buildbot, cdumez, commit-queue, darin, dbates, japhet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=130653
Attachments:
Description Flags
Crash Log
none
Patch none

Matt Lewis
Reported 2017-08-02 18:52:12 PDT
Created attachment 317061 [details] Crash Log Crash In: com.apple.WebCore:WebCore::FrameLoader::checkLoadComplete() + 90 (FrameLoader.cpp:2502) http/tests/appcache/deferred-events-delete-while-raising-timer.html is crashing on all debug testers according to the dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fappcache%2Fdeferred-events-delete-while-raising-timer.html This crash started after: https://trac.webkit.org/changeset/220052/webkit Build: https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r220159%20(2753)/results.html https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK1%20(Tests)/builds/2753
Attachments
Crash Log (99.34 KB, text/plain)
2017-08-02 18:52 PDT, Matt Lewis 		no flags
Details
Patch (3.12 KB, patch)
2017-08-15 09:14 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matt Lewis
Comment 1 2017-08-02 18:56:54 PDT
Marked test as flaky for now: https://trac.webkit.org/changeset/220174/webkit
Darin Adler
Comment 2 2017-08-03 09:45:17 PDT
This is an incorrect assertion. The fix is to move the assertion down past the null check of "page".
Darin Adler
Comment 3 2017-08-03 09:46:05 PDT
Unfortunately I don’t have time to make the fix before coming in for the day. Someone else is welcome to fix it if you want a fix before I get to it.
Darin Adler
Comment 4 2017-08-15 09:14:54 PDT
Created attachment 318124 [details] Patch
WebKit Commit Bot
Comment 5 2017-08-15 11:14:01 PDT
Comment on attachment 318124 [details] Patch Clearing flags on attachment: 318124 Committed r220750: <http://trac.webkit.org/changeset/220750>
WebKit Commit Bot
Comment 6 2017-08-15 11:14:03 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-08-15 11:14:34 PDT
<rdar://problem/33899758>
Note You need to log in before you can comment on or make changes to this bug.