Bug 175107

Summary: REGRESSION(r220052): http/tests/appcache/deferred-events-delete-while-raising-timer.html is crashing.
Product: WebKit Reporter: Matt Lewis <jlewis3>
Component: New BugsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, buildbot, cdumez, commit-queue, darin, dbates, japhet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=130653
Attachments:
Description Flags
Crash Log
none
Patch none

Description Matt Lewis 2017-08-02 18:52:12 PDT 
Created attachment 317061 [details]
Crash Log

Crash In: com.apple.WebCore:WebCore::FrameLoader::checkLoadComplete() + 90 (FrameLoader.cpp:2502)


http/tests/appcache/deferred-events-delete-while-raising-timer.html is crashing on all debug testers according to the dashboard:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fappcache%2Fdeferred-events-delete-while-raising-timer.html

This crash started after: https://trac.webkit.org/changeset/220052/webkit

Build:
https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r220159%20(2753)/results.html
https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK1%20(Tests)/builds/2753
Comment 1 Matt Lewis 2017-08-02 18:56:54 PDT 
Marked test as flaky for now:
https://trac.webkit.org/changeset/220174/webkit
Comment 2 Darin Adler 2017-08-03 09:45:17 PDT 
This is an incorrect assertion. The fix is to move the assertion down past the null check of "page".
Comment 3 Darin Adler 2017-08-03 09:46:05 PDT 
Unfortunately I don’t have time to make the fix before coming in for the day.

Someone else is welcome to fix it if you want a fix before I get to it.
Comment 4 Darin Adler 2017-08-15 09:14:54 PDT 
Created attachment 318124 [details]
Patch
Comment 5 WebKit Commit Bot 2017-08-15 11:14:01 PDT 
Comment on attachment 318124 [details]
Patch

Clearing flags on attachment: 318124

Committed r220750: <http://trac.webkit.org/changeset/220750>
Comment 6 WebKit Commit Bot 2017-08-15 11:14:03 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-08-15 11:14:34 PDT 
<rdar://problem/33899758>