Bug 175106

Summary: Use LazyNeverDestroyed instead of DEFINE_GLOBAL for WebKitFontFamilyNames
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: WebCore Misc.Assignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 174979    
Attachments:
Description Flags
WIP patch (variable version)
none
WIP patch (inline function version)
none
Patch none

Fujii Hironori
Reported 2017-08-02 18:46:13 PDT
Use LazyNeverDestroyed instead of DEFINE_GLOBAL for WebKitFontFamilyNames This is a sub-task of Bug 174979.
Attachments
WIP patch (variable version) (2.72 KB, patch)
2017-08-02 18:52 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
WIP patch (inline function version) (11.91 KB, patch)
2017-08-02 19:54 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (3.66 KB, patch)
2017-10-17 19:57 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2017-08-02 18:50:41 PDT
In Bug 174150, > And we also change emptyAtom to emptyAtom() to get the value from LazyNeverDestroyed<>. Yusuke changed emptyAtom from a varialbe to an inline function. I'm wondering how I should do. I will create two WIP patches to begin a discussion.
Fujii Hironori
Comment 2 2017-08-02 18:52:15 PDT
Created attachment 317062 [details] WIP patch (variable version)
Fujii Hironori
Comment 3 2017-08-02 19:54:05 PDT
Created attachment 317068 [details] WIP patch (inline function version)
Fujii Hironori
Comment 4 2017-08-02 19:55:56 PDT
Hi Alex and Yusuke, Which approach does look better? Give me your feedback.
Yusuke Suzuki
Comment 5 2017-08-02 20:02:08 PDT
I like the approach not using inline function if we do not need to annotate ".get()" so many.
Fujii Hironori
Comment 6 2017-10-17 19:57:35 PDT
Created attachment 324090 [details] Patch
Yusuke Suzuki
Comment 7 2017-10-18 03:37:43 PDT
Comment on attachment 324090 [details] Patch r=me
WebKit Commit Bot
Comment 8 2017-10-18 04:05:43 PDT
Comment on attachment 324090 [details] Patch Clearing flags on attachment: 324090 Committed r223600: <https://trac.webkit.org/changeset/223600>
WebKit Commit Bot
Comment 9 2017-10-18 04:05:45 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2017-10-18 04:06:55 PDT
<rdar://problem/35049570>
Note You need to log in before you can comment on or make changes to this bug.