Bug 175088

Summary: [Cocoa] Web Automation: copy JavaScript atoms to WebKit.framework private headers
Product: WebKit Reporter: Blaze Burg <bburg>
Component: WebKit2Assignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, cgarcia, commit-queue, joepeck, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch joepeck: review+, bburg: commit-queue-

Blaze Burg
Reported 2017-08-02 14:29:02 PDT
To be used by safaridriver, like Automation.json.
Attachments
Patch (6.81 KB, patch)
2017-08-02 14:48 PDT, Blaze Burg 		joepeck: review+
bburg: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2017-08-02 14:44:55 PDT
<rdar://problem/33685818>
Blaze Burg
Comment 2 2017-08-02 14:48:40 PDT
Created attachment 317003 [details] Patch
Sam Weinig
Comment 3 2017-08-02 15:52:14 PDT
Seems really weird for .js files to be in PrivateHeaders. Why not Resources?
Joseph Pecoraro
Comment 4 2017-08-02 21:07:28 PDT
> Seems really weird for .js files to be in PrivateHeaders. Why not Resources? We have perl and python files in WebCore's PrivateHeaders. I think making these PrivateHeaders is because we will want to expose them or ingest them in another framework, but not actually make them be resources of WebKit.framework?
Blaze Burg
Comment 5 2017-08-03 08:51:19 PDT
Sam and I discussed offline that private headers is how we usually share build-time resources between frameworks, due to internal build considerations. We could hypothetically put the atoms in WebKit.framework or WebDriver.framework bundle resources, but the current strategy uses xxd.pl to turn them into C++ files. So they are needed at build time not runtime.
Joseph Pecoraro
Comment 6 2017-08-03 16:30:53 PDT
Comment on attachment 317003 [details] Patch r=me
Blaze Burg
Comment 7 2017-08-04 09:44:49 PDT
Committed r220275: <http://trac.webkit.org/changeset/220275>
Note You need to log in before you can comment on or make changes to this bug.