Bug 175082

Summary: We should be OK with the gigacage being disabled on gmalloc
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: bmallocAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, cdumez, cmarcelo, dbates, ggaren, jlewis3, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=175083
Attachments:
Description Flags
the patch msaboff: review+

Filip Pizlo
Reported 2017-08-02 11:46:47 PDT
Patch forthcoming.
Attachments
the patch (7.98 KB, patch)
2017-08-02 12:28 PDT, Filip Pizlo 		msaboff: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2017-08-02 12:08:59 PDT
Easy to repro - I just need to make sure the GIGACAGE_ENABLED checks are correctly taking into account if bmalloc's DebugHeap mode is enabled.
Filip Pizlo
Comment 2 2017-08-02 12:09:08 PDT
I'm testing a fix now...
Filip Pizlo
Comment 3 2017-08-02 12:28:43 PDT
Created attachment 316982 [details] the patch
Michael Saboff
Comment 4 2017-08-02 12:33:17 PDT
Comment on attachment 316982 [details] the patch r=me
Filip Pizlo
Comment 5 2017-08-02 12:58:04 PDT
Landed in https://trac.webkit.org/changeset/220148/webkit
Radar WebKit Bug Importer
Comment 6 2017-08-02 12:58:34 PDT
<rdar://problem/33683180>
Note You need to log in before you can comment on or make changes to this bug.