Bug 175082 - We should be OK with the gigacage being disabled on gmalloc
Summary: We should be OK with the gigacage being disabled on gmalloc
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-02 11:46 PDT by Filip Pizlo
Modified: 2017-08-02 12:58 PDT (History)
12 users (show)

See Also:

Attachments
the patch (7.98 KB, patch)
2017-08-02 12:28 PDT, Filip Pizlo 		msaboff: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-08-02 11:46:47 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2017-08-02 12:08:59 PDT 
Easy to repro - I just need to make sure the GIGACAGE_ENABLED checks are correctly taking into account if bmalloc's DebugHeap mode is enabled.
Comment 2 Filip Pizlo 2017-08-02 12:09:08 PDT 
I'm testing a fix now...
Comment 3 Filip Pizlo 2017-08-02 12:28:43 PDT 
Created attachment 316982 [details]
the patch
Comment 4 Michael Saboff 2017-08-02 12:33:17 PDT 
Comment on attachment 316982 [details]
the patch

r=me
Comment 5 Filip Pizlo 2017-08-02 12:58:04 PDT 
Landed in https://trac.webkit.org/changeset/220148/webkit
Comment 6 Radar WebKit Bug Importer 2017-08-02 12:58:34 PDT 
<rdar://problem/33683180>