| Summary: | All C++ accesses to JSObject::m_butterfly should do caging | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||||||||||
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | buildbot, keith_miller, webkit-bug-importer | ||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||
| Hardware: | All | ||||||||||||||||||
| OS: | All | ||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||
| Bug Blocks: | 174917 | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Filip Pizlo
2017-08-01 11:29:07 PDT
Created attachment 316975 [details]
the patch
Comment on attachment 316975 [details] the patch Attachment 316975 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4241120 Number of test failures exceeded the failure limit. Created attachment 316984 [details]
Archive of layout-test-results from ews116 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 316985 [details]
the patch
Comment on attachment 316985 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=316985&action=review > Source/JavaScriptCore/runtime/JSObject.h:1050 > // FIXME: This should do caging. > // https://bugs.webkit.org/show_bug.cgi?id=175039 I'll remove this comment. Comment on attachment 316985 [details]
the patch
r=me.
Comment on attachment 316985 [details] the patch Attachment 316985 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4241556 Number of test failures exceeded the failure limit. Created attachment 316995 [details]
Archive of layout-test-results from ews113 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 317006 [details]
WRONG PATCH
Comment on attachment 317006 [details]
WRONG PATCH
It's alraedy been reviewed.
Created attachment 317008 [details]
maybe patch for landing
Comment on attachment 317008 [details] maybe patch for landing Attachment 317008 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4242763 New failing tests: fast/dom/StyleSheet/detached-sheet-owner-node-link.html Created attachment 317048 [details]
Archive of layout-test-results from ews114 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6
OK, these failures don't have anything to do with me. |