Bug 175039

Summary:

All C++ accesses to JSObject::m_butterfly should do caging

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, keith_miller, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

174917

Attachments:

Description	Flags
the patch	buildbot: commit-queue-
Archive of layout-test-results from ews116 for mac-elcapitan	none
the patch	keith_miller: review+, buildbot: commit-queue-
Archive of layout-test-results from ews113 for mac-elcapitan	none
WRONG PATCH	none
maybe patch for landing	buildbot: commit-queue-
Archive of layout-test-results from ews114 for mac-elcapitan	none

Filip Pizlo

Reported 2017-08-01 11:29:07 PDT

...

Attachments
the patch (24.72 KB, patch) 2017-08-02 11:00 PDT, Filip Pizlo	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews116 for mac-elcapitan (477.94 KB, application/zip) 2017-08-02 12:48 PDT, Build Bot	no flags	Details
the patch (24.74 KB, patch) 2017-08-02 12:50 PDT, Filip Pizlo	keith_miller: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews113 for mac-elcapitan (627.87 KB, application/zip) 2017-08-02 14:33 PDT, Build Bot	no flags	Details
WRONG PATCH (5.47 KB, patch) 2017-08-02 14:58 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
maybe patch for landing (24.74 KB, patch) 2017-08-02 14:58 PDT, Filip Pizlo	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews114 for mac-elcapitan (1.88 MB, application/zip) 2017-08-02 17:59 PDT, Build Bot	no flags	Details
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2017-08-02 11:00:40 PDT

Created attachment 316975 [details] the patch

Radar WebKit Bug Importer

Comment 2 2017-08-02 11:01:01 PDT

<rdar://problem/33680363>

Build Bot

Comment 3 2017-08-02 12:48:16 PDT

Comment on attachment 316975 [details] the patch Attachment 316975 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4241120 Number of test failures exceeded the failure limit.

Build Bot

Comment 4 2017-08-02 12:48:17 PDT

Created attachment 316984 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Filip Pizlo

Comment 5 2017-08-02 12:50:30 PDT

Created attachment 316985 [details] the patch

Filip Pizlo

Comment 6 2017-08-02 12:56:23 PDT

Comment on attachment 316985 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=316985&action=review > Source/JavaScriptCore/runtime/JSObject.h:1050 > // FIXME: This should do caging. > // https://bugs.webkit.org/show_bug.cgi?id=175039 I'll remove this comment.

Keith Miller

Comment 7 2017-08-02 13:08:27 PDT

Comment on attachment 316985 [details] the patch r=me.

Build Bot

Comment 8 2017-08-02 14:33:32 PDT

Comment on attachment 316985 [details] the patch Attachment 316985 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4241556 Number of test failures exceeded the failure limit.

Build Bot

Comment 9 2017-08-02 14:33:33 PDT

Created attachment 316995 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Filip Pizlo

Comment 10 2017-08-02 14:58:16 PDT

Created attachment 317006 [details] WRONG PATCH

Filip Pizlo

Comment 11 2017-08-02 14:58:34 PDT

Comment on attachment 317006 [details] WRONG PATCH It's alraedy been reviewed.

Filip Pizlo

Comment 12 2017-08-02 14:58:55 PDT

Created attachment 317008 [details] maybe patch for landing

Build Bot

Comment 13 2017-08-02 17:59:34 PDT

Comment on attachment 317008 [details] maybe patch for landing Attachment 317008 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4242763 New failing tests: fast/dom/StyleSheet/detached-sheet-owner-node-link.html

Build Bot

Comment 14 2017-08-02 17:59:35 PDT

Created attachment 317048 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Filip Pizlo

Comment 15 2017-08-02 18:29:41 PDT

OK, these failures don't have anything to do with me.

Filip Pizlo

Comment 16 2017-08-02 18:32:24 PDT

Landed in https://trac.webkit.org/changeset/220165/webkit

Note You need to log in before you can comment on or make changes to this bug.