| Summary: | Put g_gigacageBasePtr into its own page and make it read-only | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||
| Component: | bmalloc | Assignee: | Filip Pizlo <fpizlo> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | buildbot, ggaren, keith_miller, mark.lam, mitz, msaboff, saam, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 174917 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Filip Pizlo
2017-07-29 12:16:42 PDT
Created attachment 321904 [details]
the patch
Attachment 321904 [details] did not pass style-queue:
ERROR: Source/bmalloc/bmalloc/Gigacage.cpp:36: g_gigacageBasePtrs is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
Total errors found: 1 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 321904 [details]
the patch
r=me
Comment on attachment 321904 [details] the patch Attachment 321904 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4671498 New failing tests: compositing/contents-format/subpixel-antialiased-text-configs.html compositing/canvas/accelerated-canvas-compositing.html compositing/canvas/accelerated-canvas-compositing-size-limit.html accessibility/mac/abbr-acronym-tags.html compositing/clipping/border-radius-overflow-hidden-stacking-context.html compositing/contents-opaque/background-clip.html compositing/culling/clear-fixed-iframe.html compositing/contents-format/subpixel-antialiased-text-configs-antialiasing-style.html accessibility/text-marker/character-offset-visible-position-conversion-hang.html compositing/animation/animated-composited-inside-hidden.html compositing/culling/filter-occlusion-alpha.html compositing/culling/filter-occlusion-alpha-large.html accessibility/mac/value-change/value-change-user-info-contenteditable.html animations/CSSKeyframesRule-name-null.html compositing/absolute-inside-out-of-view-fixed.html compositing/filters/opacity-change-on-filtered-paints-into-ancestor.html Created attachment 321926 [details]
Archive of layout-test-results from ews115 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 321936 [details]
the patch
Attachment 321936 [details] did not pass style-queue:
ERROR: Source/bmalloc/bmalloc/Gigacage.cpp:36: g_gigacageBasePtrs is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
Total errors found: 1 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 321936 [details]
the patch
Clear r? because this patch is already reviewed.
|