Summary: | Multiple API failures on all testers with URLSchemeHandler and IconLoading | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matt Lewis <jlewis3> | ||||
Component: | New Bugs | Assignee: | Brady Eidson <beidson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, beidson, commit-queue, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Matt Lewis
2017-07-28 14:23:04 PDT
These tests are actually completing successfully, then hanging during test tear down. A very simple fix makes 7 of these work. Exploring what's up with NoMIMEType now... (In reply to Brady Eidson from comment #2) > A very simple fix makes 7 of these work. > > Exploring what's up with NoMIMEType now... Answer - The test is bogus! Created attachment 316679 [details]
Patch
Comment on attachment 316679 [details] Patch Clearing flags on attachment: 316679 Committed r220033: <http://trac.webkit.org/changeset/220033> All reviewed patches have been landed. Closing bug. The API test URLSchemeHandler.Exceptions is still failing unexpectedly on Mac Debug testers. Sierra WK2: https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK2%20%28Tests%29/builds/2281 Sierra WK1: https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK1%20%28Tests%29/builds/2703 El Capitan WK2: https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK2%20%28Tests%29/builds/2334 El Capitan WK1: https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK1%20%28Tests%29/builds/2716 It is flaky on iOS Debug often passing when the test URLSchemeHandler.Leaks1 times out. The error given is: UNEXPECTEDLY EXITED URLSchemeHandler.Exceptions 2017-07-31 06:21:28.036 TestWebKitAPI[59294:40826290] -[NSError init] called; this results in an invalid NSError instance. It will raise an exception in a future release. Please call errorWithDomain:code:userInfo: or initWithDomain:code:userInfo:. This message shown only once. After further digging and talking with Brady, the Leaks1 does not look to be related as the test was added after the others. In addition this shows Exception failing when Leaks1 times out: https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Debug%20WK2%20(Tests)/builds/3024 (In reply to Matt Lewis from comment #8) > The API test URLSchemeHandler.Exceptions is still failing unexpectedly on > Mac Debug testers. > > > The error given is: > UNEXPECTEDLY EXITED URLSchemeHandler.Exceptions > 2017-07-31 06:21:28.036 TestWebKitAPI[59294:40826290] -[NSError init] > called; this results in an invalid NSError instance. It will raise an > exception in a future release. Please call errorWithDomain:code:userInfo: or > initWithDomain:code:userInfo:. This message shown only once. The [NSError init] is (probably) irrelevant. The test is crashing. I installed a fresh install of Sierra 10.12.4 and did a clean debug build of ToT WebKit and cannot reproduce this problem. Could you dig up a crash log? Also, let's move to a new bug - There's absolutely no indication that the bug originally reported here is *not* fixed. The bots are seeing something different. |