| Summary: | [Curl] Add abstraction layer of cookie jar implementation for Curl port | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Basuke Suzuki <Basuke.Suzuki> | ||||||
| Component: | WebCore Misc. | Assignee: | Basuke Suzuki <Basuke.Suzuki> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, Basuke.Suzuki, bfulgham, buildbot, commit-queue, don.olmstead, galpeter, pvollan, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 117300, 174942 | ||||||||
| Attachments: |
|
||||||||
|
Description
Basuke Suzuki
2017-07-28 10:31:51 PDT
Created attachment 317266 [details]
Implemented
To implement further improvement for cookie jar, I've added abstract class to switch easily to new implementation while supporting current method. SQLite implementation will follow.
Comment on attachment 317266 [details] Implemented Attachment 317266 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4254697 New failing tests: media/video-canvas-createPattern.html Created attachment 317277 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Comment on attachment 317266 [details]
Implemented
I have no idea how I can break ios-sim build by this patch. I'm sure this patch only related to Curl port.
Comment on attachment 317266 [details]
Implemented
I don't believe the iOS-sim failure is related to this patch. This seems like a fine refactoring for the CURL ports.
Comment on attachment 317266 [details] Implemented Clearing flags on attachment: 317266 Committed r220351: <http://trac.webkit.org/changeset/220351> All reviewed patches have been landed. Closing bug. |