Bug 174943

Summary:

[Curl] Add abstraction layer of cookie jar implementation for Curl port

Product:

WebKit

Reporter:

Basuke Suzuki <basuke>

Component:

WebCore Misc.

Assignee:

Basuke Suzuki <basuke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, basuke, bfulgham, buildbot, commit-queue, don.olmstead, galpeter, pvollan, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

117300, 174942

Attachments:

Description	Flags
Implemented	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none

Basuke Suzuki

Reported 2017-07-28 10:31:51 PDT

To switch the implementation of cookie jar interface, add abstraction class to support basic feature of cookie jar and move current file implementation to new concrete class which implement that interface.

Attachments
Implemented (12.07 KB, patch) 2017-08-04 12:16 PDT, Basuke Suzuki	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (1.06 MB, application/zip) 2017-08-04 13:47 PDT, Build Bot	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Basuke Suzuki

Comment 1 2017-08-04 12:16:53 PDT

Created attachment 317266 [details] Implemented To implement further improvement for cookie jar, I've added abstract class to switch easily to new implementation while supporting current method. SQLite implementation will follow.

Build Bot

Comment 2 2017-08-04 13:47:26 PDT

Comment on attachment 317266 [details] Implemented Attachment 317266 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4254697 New failing tests: media/video-canvas-createPattern.html

Build Bot

Comment 3 2017-08-04 13:47:27 PDT

Created attachment 317277 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

Basuke Suzuki

Comment 4 2017-08-07 13:01:49 PDT

Comment on attachment 317266 [details] Implemented I have no idea how I can break ios-sim build by this patch. I'm sure this patch only related to Curl port.

Brent Fulgham

Comment 5 2017-08-07 13:29:46 PDT

Comment on attachment 317266 [details] Implemented I don't believe the iOS-sim failure is related to this patch. This seems like a fine refactoring for the CURL ports.

WebKit Commit Bot

Comment 6 2017-08-07 13:58:54 PDT

Comment on attachment 317266 [details] Implemented Clearing flags on attachment: 317266 Committed r220351: <http://trac.webkit.org/changeset/220351>

WebKit Commit Bot

Comment 7 2017-08-07 13:58:55 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 8 2017-08-07 13:59:47 PDT

<rdar://problem/33760982>

Note You need to log in before you can comment on or make changes to this bug.