Bug 174943

Summary: [Curl] Add abstraction layer of cookie jar implementation for Curl port
Product: WebKit Reporter: Basuke Suzuki <Basuke.Suzuki>
Component: WebCore Misc.Assignee: Basuke Suzuki <Basuke.Suzuki>
Severity: Normal CC: achristensen, Basuke.Suzuki, bfulgham, buildbot, commit-queue, don.olmstead, galpeter, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 117300, 174942    
Description Flags
Archive of layout-test-results from ews124 for ios-simulator-wk2 none

Description Basuke Suzuki 2017-07-28 10:31:51 PDT
To switch the implementation of cookie jar interface, add abstraction class to support basic feature of cookie jar and move current file implementation to new concrete class which implement that interface.
Comment 1 Basuke Suzuki 2017-08-04 12:16:53 PDT
Created attachment 317266 [details]

To implement further improvement for cookie jar, I've added abstract class to switch easily to new implementation while supporting current method. SQLite implementation will follow.
Comment 2 Build Bot 2017-08-04 13:47:26 PDT
Comment on attachment 317266 [details]

Attachment 317266 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4254697

New failing tests:
Comment 3 Build Bot 2017-08-04 13:47:27 PDT
Created attachment 317277 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 4 Basuke Suzuki 2017-08-07 13:01:49 PDT
Comment on attachment 317266 [details]

I have no idea how I can break ios-sim build by this patch. I'm sure this patch only related to Curl port.
Comment 5 Brent Fulgham 2017-08-07 13:29:46 PDT
Comment on attachment 317266 [details]

I don't believe the iOS-sim failure is related to this patch. This seems like a fine refactoring for the CURL ports.
Comment 6 WebKit Commit Bot 2017-08-07 13:58:54 PDT
Comment on attachment 317266 [details]

Clearing flags on attachment: 317266

Committed r220351: <http://trac.webkit.org/changeset/220351>
Comment 7 WebKit Commit Bot 2017-08-07 13:58:55 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-08-07 13:59:47 PDT