build-wxwebkit build script fixes

• Component: WebKit wx
• Status: RESOLVED FIXED

[Robin Dunn]

Attached patch fixes and streamlines a few minor issues in build-wxwebscript.

[Robin Dunn]

Created attachment 19282 [details]
patch for build-wxwebkit

[David Kilzer (:ddkilzer)]

Comment on attachment 19282 [details]
patch for build-wxwebkit

Thanks for the patch, Robin!  In the future, please set the "review?" flag to make sure it gets reviewed.

[Darin Adler]

Comment on attachment 19282 [details]
patch for build-wxwebkit

rs=me

[David Kilzer (:ddkilzer)]

(In reply to comment #3)
> (From update of attachment 19282 [details] [edit])
> rs=me

I think Kevin should land this patch, or review it before it's landed.

[David Kilzer (:ddkilzer)]

Comment on attachment 19282 [details]
patch for build-wxwebkit

Marking as r- since there are tabs in the patch.  They will need to be removed before landing if the patch is otherwise correct.

[David Kilzer (:ddkilzer)]

See Item 1 on the code style guidelines page:

http://webkit.org/coding/coding-style.html

[Robin Dunn]

Created attachment 19301 [details]
tab-less version of the same patch

I usually do avoid using tabs, but emacs shell-script mode uses them by default.  Tab-less version attached.

[Kevin Ollivier]

Landed in r30614, thanks!

[Maciej Stachowiak]

Comment on attachment 19301 [details]
tab-less version of the same patch

Since this is in, removin flag to get out of the review queue.