Bug 17492 - build-wxwebkit build script fixes
Summary: build-wxwebkit build script fixes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit wx (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-22 14:42 PST by Robin Dunn
Modified: 2008-04-22 22:30 PDT (History)
1 user (show)

See Also:


Attachments
patch for build-wxwebkit (5.05 KB, patch)
2008-02-22 14:42 PST, Robin Dunn
ddkilzer: review-
Details | Formatted Diff | Diff
tab-less version of the same patch (5.35 KB, patch)
2008-02-23 11:04 PST, Robin Dunn
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Dunn 2008-02-22 14:42:00 PST
Attached patch fixes and streamlines a few minor issues in build-wxwebscript.
Comment 1 Robin Dunn 2008-02-22 14:42:58 PST
Created attachment 19282 [details]
patch for build-wxwebkit
Comment 2 David Kilzer (:ddkilzer) 2008-02-22 15:18:43 PST
Comment on attachment 19282 [details]
patch for build-wxwebkit

Thanks for the patch, Robin!  In the future, please set the "review?" flag to make sure it gets reviewed.
Comment 3 Darin Adler 2008-02-23 09:27:01 PST
Comment on attachment 19282 [details]
patch for build-wxwebkit

rs=me
Comment 4 David Kilzer (:ddkilzer) 2008-02-23 09:42:49 PST
(In reply to comment #3)
> (From update of attachment 19282 [details] [edit])
> rs=me

I think Kevin should land this patch, or review it before it's landed.

Comment 5 David Kilzer (:ddkilzer) 2008-02-23 09:45:30 PST
Comment on attachment 19282 [details]
patch for build-wxwebkit

Marking as r- since there are tabs in the patch.  They will need to be removed before landing if the patch is otherwise correct.
Comment 6 David Kilzer (:ddkilzer) 2008-02-23 09:46:22 PST
See Item 1 on the code style guidelines page:

http://webkit.org/coding/coding-style.html

Comment 7 Robin Dunn 2008-02-23 11:04:23 PST
Created attachment 19301 [details]
tab-less version of the same patch

I usually do avoid using tabs, but emacs shell-script mode uses them by default.  Tab-less version attached.
Comment 8 Kevin Ollivier 2008-02-26 17:57:27 PST
Landed in r30614, thanks!
Comment 9 Maciej Stachowiak 2008-04-22 22:30:43 PDT
Comment on attachment 19301 [details]
tab-less version of the same patch

Since this is in, removin flag to get out of the review queue.