Bug 174870

Summary: Remove duplicate code from Buildbot.js in dashboard
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, dbates, jmarcell, lforschler
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
dbates: review+
Patch for landing none

Aakash Jain
Reported 2017-07-26 13:07:49 PDT
Some of the code in dashboard/Scripts/Buildbot.js is duplicated. We should remove the duplication.
Attachments
Proposed patch (3.02 KB, patch)
2017-07-26 13:13 PDT, Aakash Jain 		dbates: review+
DetailsFormatted DiffDiff
Patch for landing (3.01 KB, patch)
2017-07-26 13:59 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2017-07-26 13:13:18 PDT
Created attachment 316468 [details] Proposed patch
Daniel Bates
Comment 2 2017-07-26 13:46:41 PDT
Comment on attachment 316468 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=316468&action=review > Tools/ChangeLog:9 > + (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Removing duplicate code and reusing buildPageURLForIteration() to construct URL. reusing => reuse
Aakash Jain
Comment 3 2017-07-26 13:59:52 PDT
Created attachment 316477 [details] Patch for landing
WebKit Commit Bot
Comment 4 2017-07-26 14:38:07 PDT
Comment on attachment 316477 [details] Patch for landing Clearing flags on attachment: 316477 Committed r219963: <http://trac.webkit.org/changeset/219963>
WebKit Commit Bot
Comment 5 2017-07-26 14:38:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.