Bug 174870

Summary:

Remove duplicate code from Buildbot.js in dashboard

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, commit-queue, dbates, jmarcell, lforschler

Priority:

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	dbates: review+
Patch for landing	none

Description Aakash Jain 2017-07-26 13:07:49 PDT

Some of the code in dashboard/Scripts/Buildbot.js is duplicated. We should remove the duplication.

Comment 1 Aakash Jain 2017-07-26 13:13:18 PDT

Created attachment 316468 [details]
Proposed patch

Comment 2 Daniel Bates 2017-07-26 13:46:41 PDT

Comment on attachment 316468 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316468&action=review

> Tools/ChangeLog:9
> +        (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Removing duplicate code and reusing buildPageURLForIteration() to construct URL.

reusing => reuse

Comment 3 Aakash Jain 2017-07-26 13:59:52 PDT

Created attachment 316477 [details]
Patch for landing

Comment 4 WebKit Commit Bot 2017-07-26 14:38:07 PDT

Comment on attachment 316477 [details]
Patch for landing

Clearing flags on attachment: 316477

Committed r219963: <http://trac.webkit.org/changeset/219963>

Comment 5 WebKit Commit Bot 2017-07-26 14:38:09 PDT

All reviewed patches have been landed.  Closing bug.