Bug 174870 - Remove duplicate code from Buildbot.js in dashboard
Summary: Remove duplicate code from Buildbot.js in dashboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-26 13:07 PDT by Aakash Jain
Modified: 2017-07-26 14:38 PDT (History)
5 users (show)

See Also:

Attachments
Proposed patch (3.02 KB, patch)
2017-07-26 13:13 PDT, Aakash Jain 		dbates: review+
Details | Formatted Diff | Diff
Patch for landing (3.01 KB, patch)
2017-07-26 13:59 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2017-07-26 13:07:49 PDT 
Some of the code in dashboard/Scripts/Buildbot.js is duplicated. We should remove the duplication.
Comment 1 Aakash Jain 2017-07-26 13:13:18 PDT 
Created attachment 316468 [details]
Proposed patch
Comment 2 Daniel Bates 2017-07-26 13:46:41 PDT 
Comment on attachment 316468 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316468&action=review

> Tools/ChangeLog:9
> +        (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Removing duplicate code and reusing buildPageURLForIteration() to construct URL.

reusing => reuse
Comment 3 Aakash Jain 2017-07-26 13:59:52 PDT 
Created attachment 316477 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2017-07-26 14:38:07 PDT 
Comment on attachment 316477 [details]
Patch for landing

Clearing flags on attachment: 316477

Committed r219963: <http://trac.webkit.org/changeset/219963>
Comment 5 WebKit Commit Bot 2017-07-26 14:38:09 PDT 
All reviewed patches have been landed.  Closing bug.