Bug 174855

Summary: [CMake] WebKitFS.cmake depends on options set in Option cmake files that are included later
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bugs-noreply, commit-queue, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: Gtk, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Carlos Garcia Campos
Reported 2017-07-26 01:35:25 PDT
WebKitFS.cmake creates the derived sources directories for WebCore, WebKit and WebDriver, but checking ENABLE options that are set in OptionPort files included later. We are already creating those directories in the specirfic makefiles of WebCore, WebKit and WebDriver, probably as a workaround to this. So, we should either create the directories unconditionally in WebKitFS (it's just a hamrless empty dir in case the option is not enabled) and remove the MAKE_DIRECTORY from all other makefiles, or keep it in the other makefiles and simply remove them from WebKitFS.cmake.
Attachments
Patch (6.11 KB, patch)
2017-07-31 13:47 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2017-07-31 13:47:44 PDT
Created attachment 316798 [details] Patch
WebKit Commit Bot
Comment 2 2017-08-01 01:08:59 PDT
Comment on attachment 316798 [details] Patch Clearing flags on attachment: 316798 Committed r220091: <http://trac.webkit.org/changeset/220091>
WebKit Commit Bot
Comment 3 2017-08-01 01:09:01 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2017-08-01 01:09:34 PDT
<rdar://problem/33648858>
Michael Catanzaro
Comment 5 2017-08-01 02:00:32 PDT
Why was this imported to rdar? Did it break something?
Note You need to log in before you can comment on or make changes to this bug.