Bug 174851

Summary:

Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

Tools / Tests

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, lforschler

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	cdumez: review+
For landing after EWS	none
Patch	none
Patch	none

Brady Eidson

Reported 2017-07-25 23:09:13 PDT

Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics Followup to https://trac.webkit.org/changeset/219904/webkit

Attachments
Patch (6.73 KB, patch) 2017-07-26 10:40 PDT, Brady Eidson	cdumez: review+	Details Formatted Diff Diff
For landing after EWS (6.73 KB, text/plain) 2017-07-26 11:10 PDT, Brady Eidson	no flags	Details
Patch (6.78 KB, patch) 2017-07-26 11:12 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (6.78 KB, patch) 2017-07-26 11:48 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2017-07-25 23:25:27 PDT

Namely Databases and Plugin processes.

Brady Eidson

Comment 2 2017-07-26 10:40:03 PDT

Created attachment 316453 [details] Patch

Chris Dumez

Comment 3 2017-07-26 10:57:13 PDT

Comment on attachment 316453 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316453&action=review r=me with comment. > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:126 > + EXPECT_EQ([sharedProcessPool _databaseProcessIdentifier], (pid_t)0); The version of gtest we're using seems to still expect the expected value to come first? from gtest.h #define EXPECT_EQ(expected, actual) ...

Brady Eidson

Comment 4 2017-07-26 11:10:32 PDT

Created attachment 316456 [details] For landing after EWS

Brady Eidson

Comment 5 2017-07-26 11:12:16 PDT

Created attachment 316457 [details] Patch

Brady Eidson

Comment 6 2017-07-26 11:48:59 PDT

Created attachment 316460 [details] Patch

WebKit Commit Bot

Comment 7 2017-07-26 13:00:06 PDT

Comment on attachment 316460 [details] Patch Clearing flags on attachment: 316460 Committed r219958: <http://trac.webkit.org/changeset/219958>

WebKit Commit Bot

Comment 8 2017-07-26 13:00:08 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.