Bug 174850

Summary: Don't override _allowsMediaDocumentInlinePlayback in MediaDocument with playsinlineAttr
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: MediaAssignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, graouts, jer.noble, jonlee, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing. none

Jeremy Jones
Reported 2017-07-25 18:19:46 PDT
Don't override _allowsMediaDocumentInlinePlayback in MediaDocuemnt with playsinlineAttr.
Attachments
Patch (1.73 KB, patch)
2017-07-25 18:24 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Patch (4.22 KB, patch)
2017-07-27 18:23 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Patch for landing. (3.69 KB, patch)
2017-07-27 21:01 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jeremy Jones
Comment 1 2017-07-25 18:21:07 PDT
rdar://problem/33449903
Jeremy Jones
Comment 2 2017-07-25 18:24:00 PDT
Created attachment 316415 [details] Patch
Jeremy Jones
Comment 3 2017-07-27 18:23:33 PDT
Created attachment 316589 [details] Patch
Jon Lee
Comment 4 2017-07-27 20:10:58 PDT
Comment on attachment 316589 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316589&action=review > Source/WebCore/ChangeLog:3 > + Don't override _allowsMediaDocumentInlinePlayback in MediaDocuemnt with playsinlineAttr. MediaDocument. > Source/WebCore/ChangeLog:9 > + This change removes playsinlineAttr from MediaDocuemnt so that it doesn't override the setting MediaDocument > Source/WebCore/ChangeLog:24 > +2017-07-25 Jeremy Jones <jeremyj@apple.com> Double.
Jeremy Jones
Comment 5 2017-07-27 21:00:31 PDT
(In reply to Jon Lee from comment #4) > Comment on attachment 316589 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=316589&action=review > > > Source/WebCore/ChangeLog:3 > > + Don't override _allowsMediaDocumentInlinePlayback in MediaDocuemnt with playsinlineAttr. > > MediaDocument. Fixed. > > > Source/WebCore/ChangeLog:9 > > + This change removes playsinlineAttr from MediaDocuemnt so that it doesn't override the setting > > MediaDocument Fixed. > > > Source/WebCore/ChangeLog:24 > > +2017-07-25 Jeremy Jones <jeremyj@apple.com> > > Double. Removed.
Jeremy Jones
Comment 6 2017-07-27 21:01:05 PDT
Created attachment 316611 [details] Patch for landing.
WebKit Commit Bot
Comment 7 2017-07-27 21:41:17 PDT
Comment on attachment 316611 [details] Patch for landing. Clearing flags on attachment: 316611 Committed r219992: <http://trac.webkit.org/changeset/219992>
Note You need to log in before you can comment on or make changes to this bug.