Bug 174846

Summary: Remove Broken CompareEq constant folding phase.
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: JavaScriptCoreAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch saam: review+

Keith Miller
Reported 2017-07-25 17:09:38 PDT
This phase is broken because it can lead to patterns that we don't know how to generate.
Attachments
Patch (2.21 KB, patch)
2017-07-25 17:19 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (2.38 KB, patch)
2017-07-25 17:20 PDT, Keith Miller 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2017-07-25 17:11:45 PDT
rdar://problem/32978808
Keith Miller
Comment 2 2017-07-25 17:19:19 PDT
Created attachment 316409 [details] Patch
Keith Miller
Comment 3 2017-07-25 17:20:41 PDT
Created attachment 316411 [details] Patch
Saam Barati
Comment 4 2017-07-25 17:34:31 PDT
Comment on attachment 316411 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316411&action=review > Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:138 > + // FIXME: We should add back the broken folding phase here for comparisions with thing we prove one side has type SpecOther. thing => things. Also, please add bug URL or remove FIXME.
Keith Miller
Comment 5 2017-07-25 17:44:25 PDT
Comment on attachment 316411 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316411&action=review >> Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:138 >> + // FIXME: We should add back the broken folding phase here for comparisions with thing we prove one side has type SpecOther. > > thing => things. > > Also, please add bug URL or remove FIXME. Fixed.
Keith Miller
Comment 6 2017-07-25 17:49:31 PDT
Landed in: https://trac.webkit.org/changeset/219895/webkit
Note You need to log in before you can comment on or make changes to this bug.