Bug 174841

Summary: [Apple Pay] Add "carteBancaire" as a supported payment network
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bdakin, commit-queue, darin, sam, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Andy Estes
Reported 2017-07-25 16:00:49 PDT
[Apple Pay] Add "carteBancaire" as a supported payment network
Attachments
Patch (6.97 KB, patch)
2017-07-25 16:04 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (6.95 KB, patch)
2017-07-25 16:06 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (7.02 KB, patch)
2017-07-25 16:07 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2017-07-25 16:01:46 PDT
rdar://problem/31935596
Andy Estes
Comment 2 2017-07-25 16:04:26 PDT
Created attachment 316401 [details] Patch
Andy Estes
Comment 3 2017-07-25 16:06:43 PDT
Created attachment 316402 [details] Patch
Andy Estes
Comment 4 2017-07-25 16:07:58 PDT
Created attachment 316403 [details] Patch
Alex Christensen
Comment 5 2017-07-25 16:11:09 PDT
Comment on attachment 316403 [details] Patch r=me We should not have to maintain a list of financial institutions in WebKit. Please move to a better place.
Tim Horton
Comment 6 2017-07-25 16:11:33 PDT
Comment on attachment 316403 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316403&action=review > LayoutTests/http/tests/ssl/applepay/ApplePaySessionV3.html:18 > + supportedNetworks: ['visa', 'masterCard', 'carteBancaire'], Why doesn't this change an expected result?
Andy Estes
Comment 7 2017-07-25 16:13:10 PDT
(In reply to Tim Horton from comment #6) > Comment on attachment 316403 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=316403&action=review > > > LayoutTests/http/tests/ssl/applepay/ApplePaySessionV3.html:18 > > + supportedNetworks: ['visa', 'masterCard', 'carteBancaire'], > > Why doesn't this change an expected result? Because "carteBancaire" is a supported network in v3. I added it there as a defense in case we start throwing an error in v3 or later.
Andy Estes
Comment 8 2017-07-25 16:18:50 PDT
(In reply to Alex Christensen from comment #5) > Comment on attachment 316403 [details] > Patch > > r=me > We should not have to maintain a list of financial institutions in WebKit. > Please move to a better place. We have a radar tracking that (rdar://problem/33244118). Thanks for the review!
WebKit Commit Bot
Comment 9 2017-07-25 18:03:33 PDT
Comment on attachment 316403 [details] Patch Clearing flags on attachment: 316403 Committed r219896: <http://trac.webkit.org/changeset/219896>
WebKit Commit Bot
Comment 10 2017-07-25 18:03:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.