Bug 174840

Summary:

Web Inspector: Fix warnings about console.assert lines without semicolons

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, inspector-bugzilla-changes, joepeck

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2017-07-25 15:59:02 PDT

Fix warnings about console.assert lines without semicolons' $ ./Scripts/copy-user-interface-resources-dryrun.rb $d/foo WARNING: console.assert missing trailing semicolon on line 50001: console.assert(navigationItem, "Missing navigation item for settings view.", settingsView) WARNING: console.assert missing trailing semicolon on line 50046: console.assert(index !== -1, "SettingsView not found.", settingsView)

Attachments
[PATCH] Proposed Fix (2.07 KB, patch) 2017-07-25 16:01 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2017-07-25 16:01:38 PDT

Created attachment 316400 [details] [PATCH] Proposed Fix

Blaze Burg

Comment 2 2017-07-25 17:17:27 PDT

Comment on attachment 316400 [details] [PATCH] Proposed Fix rs=me

WebKit Commit Bot

Comment 3 2017-07-25 17:45:08 PDT

Comment on attachment 316400 [details] [PATCH] Proposed Fix Clearing flags on attachment: 316400 Committed r219894: <http://trac.webkit.org/changeset/219894>

WebKit Commit Bot

Comment 4 2017-07-25 17:45:10 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.