Bug 174840 - Web Inspector: Fix warnings about console.assert lines without semicolons
Summary: Web Inspector: Fix warnings about console.assert lines without semicolons
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-25 15:59 PDT by Joseph Pecoraro
Modified: 2017-07-25 17:45 PDT (History)
4 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (2.07 KB, patch)
2017-07-25 16:01 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-07-25 15:59:02 PDT
Fix warnings about console.assert lines without semicolons'

$ ./Scripts/copy-user-interface-resources-dryrun.rb $d/foo
WARNING: console.assert missing trailing semicolon on line 50001:         console.assert(navigationItem, "Missing navigation item for settings view.", settingsView)
WARNING: console.assert missing trailing semicolon on line 50046:         console.assert(index !== -1, "SettingsView not found.", settingsView)
Comment 1 Joseph Pecoraro 2017-07-25 16:01:38 PDT
Created attachment 316400 [details]
[PATCH] Proposed Fix
Comment 2 BJ Burg 2017-07-25 17:17:27 PDT
Comment on attachment 316400 [details]
[PATCH] Proposed Fix

rs=me
Comment 3 WebKit Commit Bot 2017-07-25 17:45:08 PDT
Comment on attachment 316400 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 316400

Committed r219894: <http://trac.webkit.org/changeset/219894>
Comment 4 WebKit Commit Bot 2017-07-25 17:45:10 PDT
All reviewed patches have been landed.  Closing bug.