Bug 174815

Summary: [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, clopez, darin, mcatanzaro
Priority: P2 Keywords: Regression
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch clopez: review+

Carlos Garcia Campos
Reported 2017-07-25 04:08:13 PDT
Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to use WebKit dir, while the tests are still in WebKit2 directory.
Attachments
Patch (14.62 KB, patch)
2017-07-25 04:11 PDT, Carlos Garcia Campos 		clopez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-07-25 04:11:38 PDT
Created attachment 316362 [details] Patch
Carlos Alberto Lopez Perez
Comment 2 2017-07-25 04:23:06 PDT
Comment on attachment 316362 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316362&action=review > Tools/ChangeLog:10 > + ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to > + use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes I think the patch is fine for fixing this issue now, But I suggest to clarify on the bug of the rename if not applying the webkit2->webkit and webkit->webkitlegacy renaming also on the directories Tools/TestWebKitAPI/Tests was intentional or an overlook.
Carlos Garcia Campos
Comment 3 2017-07-25 04:36:58 PDT
Committed r219865: <http://trac.webkit.org/changeset/219865>
Michael Catanzaro
Comment 4 2017-07-25 07:06:41 PDT
Of course it's an oversight, we have to rename all the directories.
Darin Adler
Comment 5 2017-07-25 09:09:08 PDT
(In reply to Michael Catanzaro from comment #4) > Of course it's an oversight, we have to rename all the directories. Agreed.
Note You need to log in before you can comment on or make changes to this bug.