|Summary:||[GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename|
|Product:||WebKit||Reporter:||Carlos Garcia Campos <cgarcia>|
|Severity:||Normal||CC:||bugs-noreply, clopez, darin, mcatanzaro|
|Version:||WebKit Nightly Build|
Description Carlos Garcia Campos 2017-07-25 04:08:13 PDT
Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to use WebKit dir, while the tests are still in WebKit2 directory.
Comment 2 Carlos Alberto Lopez Perez 2017-07-25 04:23:06 PDT
Comment on attachment 316362 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316362&action=review > Tools/ChangeLog:10 > + ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to > + use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes I think the patch is fine for fixing this issue now, But I suggest to clarify on the bug of the rename if not applying the webkit2->webkit and webkit->webkitlegacy renaming also on the directories Tools/TestWebKitAPI/Tests was intentional or an overlook.
Comment 3 Carlos Garcia Campos 2017-07-25 04:36:58 PDT
Committed r219865: <http://trac.webkit.org/changeset/219865>
Comment 4 Michael Catanzaro 2017-07-25 07:06:41 PDT
Of course it's an oversight, we have to rename all the directories.