Bug 174803

Summary: Web Automation: files selected for upload should be checked against values of the 'accept' attribute
Product: WebKit Reporter: Blaze Burg <bburg>
Component: WebKit2Assignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, buildbot, cgarcia, ggaren, joepeck, jonlee, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 174797    
Bug Blocks:    
Attachments:
Description Flags
Proposed Fix
none
Proposed Fix
cgarcia: review+, buildbot: commit-queue-
Archive of layout-test-results from ews117 for mac-elcapitan none

Blaze Burg
Reported 2017-07-24 16:34:26 PDT
placeholder text.
Attachments
Proposed Fix (6.24 KB, patch)
2017-08-01 16:55 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Proposed Fix (5.79 KB, patch)
2017-08-01 16:56 PDT, Blaze Burg 		cgarcia: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews117 for mac-elcapitan (2.08 MB, application/zip)
2017-08-02 09:59 PDT, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-07-25 09:46:46 PDT
<rdar://problem/33514190>
Blaze Burg
Comment 2 2017-08-01 16:55:15 PDT
Created attachment 316913 [details] Proposed Fix
Blaze Burg
Comment 3 2017-08-01 16:56:58 PDT
Created attachment 316914 [details] Proposed Fix
Carlos Garcia Campos
Comment 4 2017-08-02 08:06:12 PDT
Comment on attachment 316914 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=316914&action=review > Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:559 > + if (!allowedMIMETypes.size()) > + continue; Nit: I usually prefer isEmpty() > Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:579 > + filesAreValid = false; > + break; I think this would be easier if we moved this loop into a function, then you could just return false instead of filesAreValid = false + break;
Build Bot
Comment 5 2017-08-02 09:58:58 PDT
Comment on attachment 316914 [details] Proposed Fix Attachment 316914 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4240379 New failing tests: fast/dom/StyleSheet/detached-sheet-owner-node-link.html
Build Bot
Comment 6 2017-08-02 09:59:00 PDT
Created attachment 316968 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Blaze Burg
Comment 7 2017-08-02 11:35:29 PDT
Committed r220147: <http://trac.webkit.org/changeset/220147>
Note You need to log in before you can comment on or make changes to this bug.