Bug 174791

Summary: [GTK][WPE] Stop using AutodrainedPool in IconDatabase
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, berto, bugs-noreply, buildbot, cgarcia, commit-queue, gustavo, mcatanzaro
Priority: P2    
Version: Other   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2017-07-24 09:23:15 PDT
AutodrainedPool seems to be some NS garbage collection thing that has no implementation on other platforms. Now that IconDatabase is used only by GTK and WPE, we can stop using it.
Attachments
Patch (4.27 KB, patch)
2017-07-24 09:25 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2017-07-24 09:25:15 PDT
Created attachment 316296 [details] Patch
Build Bot
Comment 2 2017-07-24 09:27:06 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
WebKit Commit Bot
Comment 3 2017-07-24 11:55:32 PDT
Comment on attachment 316296 [details] Patch Clearing flags on attachment: 316296 Committed r219832: <http://trac.webkit.org/changeset/219832>
WebKit Commit Bot
Comment 4 2017-07-24 11:55:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.