Summary: | [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||
Component: | WebKit2 | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aestes, commit-queue, megan_gardner, mitz, thorton | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Wenson Hsieh
2017-07-22 20:10:55 PDT
Created attachment 316222 [details]
Patch
Comment on attachment 316222 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316222&action=review > Tools/TestWebKitAPI/cocoa/TestWKWebView.h:56 > +- (_WKActivatedElementInfo *)_activatedElementAtPosition:(CGPoint)position; Probably don’t need the underscore prefix on this method’s name. It’s like the rest of the TestWKWebView methods. (In reply to mitz from comment #2) > Comment on attachment 316222 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=316222&action=review > > > Tools/TestWebKitAPI/cocoa/TestWKWebView.h:56 > > +- (_WKActivatedElementInfo *)_activatedElementAtPosition:(CGPoint)position; > > Probably don’t need the underscore prefix on this method’s name. It’s like > the rest of the TestWKWebView methods. Good catch -- fixed. I originally had it as SPI on WKWebView, and then decided to move it into TestWebKitAPI but didn't rename it. Thanks for the review! Created attachment 316224 [details]
Patch for landing
Comment on attachment 316224 [details] Patch for landing Clearing flags on attachment: 316224 Committed r219768: <http://trac.webkit.org/changeset/219768> |