Bug 174755

Summary: Merge ExceptionBase into DOMException and drop custom toString
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, darin, ggaren, jlewis3, rniwa, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 174677, 174743    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews100 for mac-elcapitan
none
Archive of layout-test-results from ews114 for mac-elcapitan
none
Archive of layout-test-results from ews124 for ios-simulator-wk2
none
Patch none

Description Chris Dumez 2017-07-22 10:06:09 PDT
Merge ExceptionBase into DOMException and drop custom toString, now that DOMException is the only remaining exception type.
Comment 1 Chris Dumez 2017-07-22 10:11:34 PDT
Created attachment 316198 [details]
Patch
Comment 2 Build Bot 2017-07-22 11:10:48 PDT
Comment on attachment 316198 [details]
Patch

Attachment 316198 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4168507

New failing tests:
http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url.html
http/tests/security/aboutBlank/xss-DENIED-set-opener.html
http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write.html
Comment 3 Build Bot 2017-07-22 11:10:49 PDT
Created attachment 316202 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Build Bot 2017-07-22 11:35:00 PDT
Comment on attachment 316198 [details]
Patch

Attachment 316198 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4168539

New failing tests:
http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write.html
http/tests/security/aboutBlank/xss-DENIED-set-opener.html
http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url.html
Comment 5 Build Bot 2017-07-22 11:35:01 PDT
Created attachment 316203 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-07-22 11:37:17 PDT
Comment on attachment 316198 [details]
Patch

Attachment 316198 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4168609

New failing tests:
fast/dynamic/015.html
editing/selection/caret-ltr-2-left.html
editing/selection/caret-rtl.html
fast/attachment/attachment-select-on-click.html
editing/selection/caret-ltr.html
editing/selection/caret-ltr-2.html
editing/selection/caret-ltr-right.html
editing/selection/caret-rtl-2.html
editing/selection/caret-rtl-2-left.html
editing/selection/caret-rtl-right.html
Comment 7 Build Bot 2017-07-22 11:37:18 PDT
Created attachment 316204 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 8 Chris Dumez 2017-07-22 11:45:49 PDT
Created attachment 316205 [details]
Patch
Comment 9 Chris Dumez 2017-07-22 14:20:30 PDT
Comment on attachment 316205 [details]
Patch

Clearing flags on attachment: 316205

Committed r219766: <http://trac.webkit.org/changeset/219766>
Comment 10 Chris Dumez 2017-07-22 14:20:32 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Matt Lewis 2017-07-25 13:56:06 PDT
Added an additional rebaseline for http/tests/quicklook/top-navigation-blocked.html
https://trac.webkit.org/changeset/219884/webkit