Summary: | [iOS] Adopt UIImagePickerControllerImageURL for photo uploads | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||||||
Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bdakin, commit-queue, darin, jiewen_tan, joepeck, jonlee, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=145539 | ||||||||||
Attachments: |
|
Description
Andy Estes
2017-07-21 12:41:45 PDT
Created attachment 316114 [details]
Patch
Created attachment 316117 [details]
Patch
Created attachment 316119 [details]
Patch
Comment on attachment 316119 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316119&action=review This looks good to me (r=me)! You'll still need WebKit2 owner's approval (if you are not an owner, maybe you are!) > Source/WebKit/ChangeLog:11 > + UIImagePickerControllerImageURLExportPresetCompatible, UIKit will take care of converting Where is this `UIImagePickerControllerImageURLExportPresetCompatible` specified by us? Or is it the default? (In reply to Joseph Pecoraro from comment #5) > Comment on attachment 316119 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=316119&action=review > > This looks good to me (r=me)! You'll still need WebKit2 owner's approval (if > you are not an owner, maybe you are!) > > > Source/WebKit/ChangeLog:11 > > + UIImagePickerControllerImageURLExportPresetCompatible, UIKit will take care of converting > > Where is this `UIImagePickerControllerImageURLExportPresetCompatible` > specified by us? Or is it the default? It's the default. Thanks for the review! Comment on attachment 316119 [details] Patch Clearing flags on attachment: 316119 Committed r219750: <http://trac.webkit.org/changeset/219750> All reviewed patches have been landed. Closing bug. |