Bug 174723

Summary: [iOS] Adopt UIImagePickerControllerImageURL for photo uploads
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, darin, jiewen_tan, joepeck, jonlee, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=145539
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Andy Estes 2017-07-21 12:41:45 PDT
[iOS] Adopt UIImagePickerControllerImageURL for photo uploads
Comment 1 Andy Estes 2017-07-21 12:44:54 PDT
rdar://problem/33223962
Comment 2 Andy Estes 2017-07-21 12:50:35 PDT
Created attachment 316114 [details]
Patch
Comment 3 Andy Estes 2017-07-21 14:01:09 PDT
Created attachment 316117 [details]
Patch
Comment 4 Andy Estes 2017-07-21 14:11:52 PDT
Created attachment 316119 [details]
Patch
Comment 5 Joseph Pecoraro 2017-07-21 14:15:43 PDT
Comment on attachment 316119 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316119&action=review

This looks good to me (r=me)! You'll still need WebKit2 owner's approval (if you are not an owner, maybe you are!)

> Source/WebKit/ChangeLog:11
> +        UIImagePickerControllerImageURLExportPresetCompatible, UIKit will take care of converting

Where is this `UIImagePickerControllerImageURLExportPresetCompatible` specified by us? Or is it the default?
Comment 6 Andy Estes 2017-07-21 14:17:07 PDT
(In reply to Joseph Pecoraro from comment #5)
> Comment on attachment 316119 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=316119&action=review
> 
> This looks good to me (r=me)! You'll still need WebKit2 owner's approval (if
> you are not an owner, maybe you are!)
> 
> > Source/WebKit/ChangeLog:11
> > +        UIImagePickerControllerImageURLExportPresetCompatible, UIKit will take care of converting
> 
> Where is this `UIImagePickerControllerImageURLExportPresetCompatible`
> specified by us? Or is it the default?

It's the default.

Thanks for the review!
Comment 7 WebKit Commit Bot 2017-07-21 15:44:35 PDT
Comment on attachment 316119 [details]
Patch

Clearing flags on attachment: 316119

Committed r219750: <http://trac.webkit.org/changeset/219750>
Comment 8 WebKit Commit Bot 2017-07-21 15:44:37 PDT
All reviewed patches have been landed.  Closing bug.