Bug 174722

Summary: AX: Expose form validation on iOS as hint
Product: WebKit Reporter: Nan Wang <n_wang>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cfleizach, commit-queue, n_wang, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch none

Description Nan Wang 2017-07-21 12:22:33 PDT
Expose form validation on iOS as hint
Comment 1 Radar WebKit Bug Importer 2017-07-21 12:23:43 PDT
<rdar://problem/33459761>
Comment 2 Nan Wang 2017-07-21 12:31:08 PDT
Created attachment 316110 [details]
patch
Comment 3 chris fleizach 2017-07-21 12:47:08 PDT
Comment on attachment 316110 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316110&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1590
> +    if (is<HTMLFormControlElement>(m_renderer->node()))

you should be able to just call node() here

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1597
> +    if (is<HTMLFormControlElement>(m_renderer->node()))

ditto

then you can probably just put this in AccessibilityObject so it doesn't have to be virtual
Comment 4 Nan Wang 2017-07-21 15:37:04 PDT
Created attachment 316129 [details]
patch

update from review
Comment 5 chris fleizach 2017-07-21 15:53:11 PDT
Comment on attachment 316129 [details]
patch

looks good, wait for bot status = green
Comment 6 WebKit Commit Bot 2017-07-21 16:25:25 PDT
Comment on attachment 316129 [details]
patch

Clearing flags on attachment: 316129

Committed r219751: <http://trac.webkit.org/changeset/219751>
Comment 7 WebKit Commit Bot 2017-07-21 16:25:27 PDT
All reviewed patches have been landed.  Closing bug.