Summary: | Noise when AudioChannel lengths don't match. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jeremy Jones <jeremyj-wk> | ||||||||
Component: | Media | Assignee: | Jeremy Jones <jeremyj-wk> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, jer.noble, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Jeremy Jones
2017-07-20 22:02:57 PDT
<rdar://problem/33389856> WebRTC 17A320/B188: Blaring static through AirPods when allowing camera/mic on webrtc session Created attachment 316068 [details]
Patch
Comment on attachment 316068 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316068&action=review > Source/WebCore/ChangeLog:9 > + When AudioChannel lengths don't match, it don't do the copy. This leaves uninitialized data in the audio buffer. Nit: "it don't do the copy. This leaves uninitialized data in the audio buffer." => "returning early leaves uninitialized data in the audio buffer." (In reply to Eric Carlson from comment #3) > Comment on attachment 316068 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=316068&action=review > > > Source/WebCore/ChangeLog:9 > > + When AudioChannel lengths don't match, it don't do the copy. This leaves uninitialized data in the audio buffer. > > Nit: "it don't do the copy. This leaves uninitialized data in the audio > buffer." => "returning early leaves uninitialized data in the audio buffer." "When AudioChannel lengths don't match it returns early leaving uninitialized data in the audio buffer." Created attachment 316111 [details]
Patch
Created attachment 316112 [details]
Patch for landing.
Eric, I accidentally wiped out your r+. Comment on attachment 316112 [details] Patch for landing. Clearing flags on attachment: 316112 Committed r219736: <http://trac.webkit.org/changeset/219736> All reviewed patches have been landed. Closing bug. |