Bug 174705

Summary:

[WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, buildbot, cdumez, cmarcelo, darin, dbates, mark.lam, saam, sam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mark.lam: review+

Description Yusuke Suzuki 2017-07-20 20:56:15 PDT

[WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult

Comment 1 Yusuke Suzuki 2017-07-20 21:00:24 PDT

Created attachment 316066 [details]
Patch

Comment 2 Mark Lam 2017-07-21 12:21:16 PDT

Comment on attachment 316066 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316066&action=review

r=me

> Source/WTF/wtf/ThreadGroup.cpp:53
> +    ThreadGroupAddResult result = add(Thread::current());

auto result?

Comment 3 Yusuke Suzuki 2017-07-21 22:13:59 PDT

Comment on attachment 316066 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316066&action=review

Thank you!

>> Source/WTF/wtf/ThreadGroup.cpp:53
>> +    ThreadGroupAddResult result = add(Thread::current());
> 
> auto result?

Sounds fine. Fixed.

Comment 4 Yusuke Suzuki 2017-07-22 00:27:11 PDT

Committed r219760: <http://trac.webkit.org/changeset/219760>