Bug 174699

Summary: Drop make_dom_exceptions.pl script that we only have DOMException
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, buildbot, cdumez, commit-queue, darin, ggaren, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 174677, 174698    
Bug Blocks:    
Attachments:
Description Flags
WIP Patch
none
WIP Patch
none
Patch none

Chris Dumez
Reported 2017-07-20 16:39:53 PDT
Drop make_dom_exceptions.pl script once we only have 1 exception type: DOMException.
Attachments
WIP Patch (33.03 KB, patch)
2017-07-21 10:31 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (33.07 KB, patch)
2017-07-21 10:46 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (33.87 KB, patch)
2017-07-21 11:44 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-07-21 10:31:17 PDT
Created attachment 316098 [details] WIP Patch
Build Bot
Comment 2 2017-07-21 10:33:46 PDT
Attachment 316098 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSDOMExceptionHandling.cpp:27: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 3 2017-07-21 10:46:44 PDT
Created attachment 316102 [details] WIP Patch
Build Bot
Comment 4 2017-07-21 10:49:28 PDT
Attachment 316102 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSDOMExceptionHandling.cpp:27: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 5 2017-07-21 11:44:06 PDT
Created attachment 316106 [details] Patch
Darin Adler
Comment 6 2017-07-21 13:24:42 PDT
Comment on attachment 316106 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316106&action=review > Source/WebCore/dom/ExceptionCodeDescription.h:37 > +#if ENABLE(INDEXED_DATABASE) > + IDBDatabaseExceptionType, > +#endif Is this staying for good? Or will this be merged later? > Source/WebCore/inspector/WebInjectedScriptHost.cpp:30 > +#include "DOMException.h" > +#include "JSDOMException.h" Surprised we need both of these. I would have thought we would only need JSDOMException.h
Chris Dumez
Comment 7 2017-07-21 13:26:45 PDT
(In reply to Darin Adler from comment #6) > Comment on attachment 316106 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=316106&action=review > > > Source/WebCore/dom/ExceptionCodeDescription.h:37 > > +#if ENABLE(INDEXED_DATABASE) > > + IDBDatabaseExceptionType, > > +#endif > > Is this staying for good? Or will this be merged later? I plan to investigate dropping IDBDatabaseException in a follow-up, given that is the last "custom" exception and dropping it would help simplify the code further. That said, I might run into trouble when trying to get rid of it, we'll see. > > > Source/WebCore/inspector/WebInjectedScriptHost.cpp:30 > > +#include "DOMException.h" > > +#include "JSDOMException.h" > > Surprised we need both of these. I would have thought we would only need > JSDOMException.h I'll double check.
WebKit Commit Bot
Comment 8 2017-07-21 13:53:04 PDT
Comment on attachment 316106 [details] Patch Clearing flags on attachment: 316106 Committed r219741: <http://trac.webkit.org/changeset/219741>
WebKit Commit Bot
Comment 9 2017-07-21 13:53:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.