Bug 174693

Summary:

Get rid of IconDatabase related code in WebKit

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebKit Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, aestes, buildbot, commit-queue, thorton

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch with <tab> fixed	none
Patch	none

Brady Eidson

Reported 2017-07-20 15:27:33 PDT

Get rid of IconDatabase related code in WebKit (As much as possible)

Attachments
Patch (80.36 KB, patch) 2017-07-20 15:49 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (82.05 KB, patch) 2017-07-20 16:04 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch with <tab> fixed (82.05 KB, patch) 2017-07-20 16:40 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (82.67 KB, patch) 2017-07-20 20:32 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2017-07-20 15:49:12 PDT

Created attachment 316033 [details] Patch

Brady Eidson

Comment 2 2017-07-20 15:49:20 PDT

Let EWS work.

Brady Eidson

Comment 3 2017-07-20 16:04:24 PDT

Created attachment 316035 [details] Patch

Build Bot

Comment 4 2017-07-20 16:07:06 PDT

Attachment 316035 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/API/C/cairo/WKIconDatabaseCairo.cpp:37: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brady Eidson

Comment 5 2017-07-20 16:40:36 PDT

Created attachment 316040 [details] Patch with <tab> fixed Not marking as a patch yet, waiting for EWS to finish on the last one.

Brady Eidson

Comment 6 2017-07-20 17:12:09 PDT

Ran API tests locally, have some API test failures to resolve (by getting rid of them) IconLoading.AlreadyCachedIcon IconLoading.DefaultFavicon IconLoading.IconLoadCancelledCallback IconLoading.IconLoadCancelledCallback2 Will do those with an updated patch for landing. (EWS SHOULD DO API TESTS!)

Brady Eidson

Comment 7 2017-07-20 19:02:38 PDT

(In reply to Brady Eidson from comment #6) > Ran API tests locally, have some API test failures to resolve (by getting > rid of them) > > IconLoading.AlreadyCachedIcon > IconLoading.DefaultFavicon > IconLoading.IconLoadCancelledCallback > IconLoading.IconLoadCancelledCallback2 > > Will do those with an updated patch for landing. > > (EWS SHOULD DO API TESTS!) Whoops, these are actually *new* tests. I know what I did wrong here. One line change in WebFrameLoaderClient, I think.

Brady Eidson

Comment 8 2017-07-20 20:32:26 PDT

Created attachment 316065 [details] Patch

Brady Eidson

Comment 9 2017-07-20 20:33:24 PDT

(In reply to Brady Eidson from comment #7) > (In reply to Brady Eidson from comment #6) > > Ran API tests locally, have some API test failures to resolve (by getting > > rid of them) > > > > IconLoading.AlreadyCachedIcon > > IconLoading.DefaultFavicon > > IconLoading.IconLoadCancelledCallback > > IconLoading.IconLoadCancelledCallback2 > > > > Will do those with an updated patch for landing. > > > > (EWS SHOULD DO API TESTS!) > > Whoops, these are actually *new* tests. I know what I did wrong here. One > line change in WebFrameLoaderClient, I think. Yup, I'd accidentally taken off the WebFrameLoaderClient method that tells WebCore to use icon loading client mode.

WebKit Commit Bot

Comment 10 2017-07-20 21:10:58 PDT

Comment on attachment 316065 [details] Patch Clearing flags on attachment: 316065 Committed r219713: <http://trac.webkit.org/changeset/219713>

WebKit Commit Bot

Comment 11 2017-07-20 21:10:59 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.