Bug 174686

Summary: Avoid unnecessary WorkQueue dispatch in WebResourceLoadStatisticsStore::processStatisticsAndDataRecords()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, ggaren, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2017-07-20 13:13:58 PDT
Avoid unnecessary WorkQueue dispatch in WebResourceLoadStatisticsStore::processStatisticsAndDataRecords(). The most common call site is already on the right thread.
Attachments
Patch (5.50 KB, patch)
2017-07-20 13:14 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (5.56 KB, patch)
2017-07-20 13:46 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (5.56 KB, patch)
2017-07-20 13:49 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-07-20 13:14:45 PDT
Created attachment 316019 [details] Patch
Brent Fulgham
Comment 2 2017-07-20 13:43:10 PDT
Comment on attachment 316019 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316019&action=review > Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:-223 > - }); Shouldn’t this be calling ‘processStatisticsAndDataRecords’ here? Seems like this is a no-op now?
Chris Dumez
Comment 3 2017-07-20 13:46:32 PDT
Created attachment 316025 [details] Patch
Geoffrey Garen
Comment 4 2017-07-20 13:47:37 PDT
Comment on attachment 316025 [details] Patch r=me
Chris Dumez
Comment 5 2017-07-20 13:49:30 PDT
Created attachment 316026 [details] Patch
Chris Dumez
Comment 6 2017-07-20 14:09:39 PDT
Comment on attachment 316026 [details] Patch Clearing flags on attachment: 316026 Committed r219705: <http://trac.webkit.org/changeset/219705>
Chris Dumez
Comment 7 2017-07-20 14:09:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.