Bug 174686 - Avoid unnecessary WorkQueue dispatch in WebResourceLoadStatisticsStore::processStatisticsAndDataRecords()
Summary: Avoid unnecessary WorkQueue dispatch in WebResourceLoadStatisticsStore::proce...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-20 13:13 PDT by Chris Dumez
Modified: 2017-07-20 14:09 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.50 KB, patch)
2017-07-20 13:14 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (5.56 KB, patch)
2017-07-20 13:46 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (5.56 KB, patch)
2017-07-20 13:49 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-07-20 13:13:58 PDT 
Avoid unnecessary WorkQueue dispatch in WebResourceLoadStatisticsStore::processStatisticsAndDataRecords(). The most common call site is already on the right thread.
Comment 1 Chris Dumez 2017-07-20 13:14:45 PDT 
Created attachment 316019 [details]
Patch
Comment 2 Brent Fulgham 2017-07-20 13:43:10 PDT 
Comment on attachment 316019 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316019&action=review

> Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:-223
> -            });

Shouldn’t this be calling ‘processStatisticsAndDataRecords’ here? Seems like this is a no-op now?
Comment 3 Chris Dumez 2017-07-20 13:46:32 PDT 
Created attachment 316025 [details]
Patch
Comment 4 Geoffrey Garen 2017-07-20 13:47:37 PDT 
Comment on attachment 316025 [details]
Patch

r=me
Comment 5 Chris Dumez 2017-07-20 13:49:30 PDT 
Created attachment 316026 [details]
Patch
Comment 6 Chris Dumez 2017-07-20 14:09:39 PDT 
Comment on attachment 316026 [details]
Patch

Clearing flags on attachment: 316026

Committed r219705: <http://trac.webkit.org/changeset/219705>
Comment 7 Chris Dumez 2017-07-20 14:09:40 PDT 
All reviewed patches have been landed.  Closing bug.