Summary: | Drop legacy XPathException type | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||
Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | achristensen, buildbot, commit-queue, darin, ggaren, rniwa, sam | ||||||||||
Priority: | P2 | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 174677 | ||||||||||||
Attachments: |
|
Description
Chris Dumez
2017-07-20 10:36:35 PDT
Created attachment 316000 [details]
Patch
Comment on attachment 316000 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316000&action=review > Source/WebCore/ChangeLog:9 > + Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome > + no longer expose XPathException. No test coverage? Comment on attachment 316000 [details] Patch Attachment 316000 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4156465 New failing tests: dom/svg/level3/xpath/XPathResult_TYPE_ERR.svg fast/dom/Window/window-lookup-precedence.html fast/xpath/4XPath/Core/test_parser.html fast/xpath/invalid-functions.html dom/svg/level3/xpath/XPathEvaluator_evaluate_INVALID_EXPRESSION_ERR.svg dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.svg dom/svg/level3/xpath/XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR.svg fast/dom/DOMException/XPathException.html fast/xpath/py-dom-xpath/expressions.html Created attachment 316008 [details]
Archive of layout-test-results from ews101 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 316009 [details]
Patch
(In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 316000 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=316000&action=review > > > Source/WebCore/ChangeLog:9 > > + Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome > > + no longer expose XPathException. > > No test coverage? No r? flag? Created attachment 316012 [details]
Patch
Comment on attachment 316012 [details] Patch Clearing flags on attachment: 316012 Committed r219706: <http://trac.webkit.org/changeset/219706> All reviewed patches have been landed. Closing bug. Reverted r219706 for reason: Broke iOS build Committed r219707: <http://trac.webkit.org/changeset/219707> Committed r219708: <http://trac.webkit.org/changeset/219708> |