RESOLVED FIXED 174679
Drop legacy XPathException type 
https://bugs.webkit.org/show_bug.cgi?id=174679
Summary Drop legacy XPathException type
Chris Dumez
Reported 2017-07-20 10:36:35 PDT
Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome no longer expose XPathException.
Attachments
Patch (31.96 KB, patch)
2017-07-20 10:50 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews101 for mac-elcapitan (1.15 MB, application/zip)
2017-07-20 11:39 PDT, Build Bot 		no flags
Details
Patch (70.12 KB, patch)
2017-07-20 11:40 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (71.38 KB, patch)
2017-07-20 12:18 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-07-20 10:50:14 PDT
Created attachment 316000 [details] Patch
Alexey Proskuryakov
Comment 2 2017-07-20 11:00:10 PDT
Comment on attachment 316000 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316000&action=review > Source/WebCore/ChangeLog:9 > + Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome > + no longer expose XPathException. No test coverage?
Build Bot
Comment 3 2017-07-20 11:39:42 PDT
Comment on attachment 316000 [details] Patch Attachment 316000 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4156465 New failing tests: dom/svg/level3/xpath/XPathResult_TYPE_ERR.svg fast/dom/Window/window-lookup-precedence.html fast/xpath/4XPath/Core/test_parser.html fast/xpath/invalid-functions.html dom/svg/level3/xpath/XPathEvaluator_evaluate_INVALID_EXPRESSION_ERR.svg dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.svg dom/svg/level3/xpath/XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR.svg fast/dom/DOMException/XPathException.html fast/xpath/py-dom-xpath/expressions.html
Build Bot
Comment 4 2017-07-20 11:39:43 PDT
Created attachment 316008 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Chris Dumez
Comment 5 2017-07-20 11:40:13 PDT
Created attachment 316009 [details] Patch
Chris Dumez
Comment 6 2017-07-20 11:41:14 PDT
(In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 316000 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=316000&action=review > > > Source/WebCore/ChangeLog:9 > > + Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome > > + no longer expose XPathException. > > No test coverage? No r? flag?
Chris Dumez
Comment 7 2017-07-20 12:18:12 PDT
Created attachment 316012 [details] Patch
WebKit Commit Bot
Comment 8 2017-07-20 15:03:49 PDT
Comment on attachment 316012 [details] Patch Clearing flags on attachment: 316012 Committed r219706: <http://trac.webkit.org/changeset/219706>
WebKit Commit Bot
Comment 9 2017-07-20 15:03:51 PDT
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 10 2017-07-20 15:45:28 PDT
Reverted r219706 for reason: Broke iOS build Committed r219707: <http://trac.webkit.org/changeset/219707>
Chris Dumez
Comment 11 2017-07-20 16:02:20 PDT
Committed r219708: <http://trac.webkit.org/changeset/219708>
Note You need to log in before you can comment on or make changes to this bug.