Bug 174679 - Drop legacy XPathException type
Summary: Drop legacy XPathException type
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 174677
  Show dependency treegraph
 
Reported: 2017-07-20 10:36 PDT by Chris Dumez
Modified: 2017-07-20 16:42 PDT (History)
7 users (show)

See Also:


Attachments
Patch (31.96 KB, patch)
2017-07-20 10:50 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-elcapitan (1.15 MB, application/zip)
2017-07-20 11:39 PDT, Build Bot
no flags Details
Patch (70.12 KB, patch)
2017-07-20 11:40 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (71.38 KB, patch)
2017-07-20 12:18 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-07-20 10:36:35 PDT
Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome no longer expose XPathException.
Comment 1 Chris Dumez 2017-07-20 10:50:14 PDT
Created attachment 316000 [details]
Patch
Comment 2 Alexey Proskuryakov 2017-07-20 11:00:10 PDT
Comment on attachment 316000 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316000&action=review

> Source/WebCore/ChangeLog:9
> +        Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
> +        no longer expose XPathException.

No test coverage?
Comment 3 Build Bot 2017-07-20 11:39:42 PDT
Comment on attachment 316000 [details]
Patch

Attachment 316000 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4156465

New failing tests:
dom/svg/level3/xpath/XPathResult_TYPE_ERR.svg
fast/dom/Window/window-lookup-precedence.html
fast/xpath/4XPath/Core/test_parser.html
fast/xpath/invalid-functions.html
dom/svg/level3/xpath/XPathEvaluator_evaluate_INVALID_EXPRESSION_ERR.svg
dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.svg
dom/svg/level3/xpath/XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR.svg
fast/dom/DOMException/XPathException.html
fast/xpath/py-dom-xpath/expressions.html
Comment 4 Build Bot 2017-07-20 11:39:43 PDT
Created attachment 316008 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 5 Chris Dumez 2017-07-20 11:40:13 PDT
Created attachment 316009 [details]
Patch
Comment 6 Chris Dumez 2017-07-20 11:41:14 PDT
(In reply to Alexey Proskuryakov from comment #2)
> Comment on attachment 316000 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=316000&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
> > +        no longer expose XPathException.
> 
> No test coverage?

No r? flag?
Comment 7 Chris Dumez 2017-07-20 12:18:12 PDT
Created attachment 316012 [details]
Patch
Comment 8 WebKit Commit Bot 2017-07-20 15:03:49 PDT
Comment on attachment 316012 [details]
Patch

Clearing flags on attachment: 316012

Committed r219706: <http://trac.webkit.org/changeset/219706>
Comment 9 WebKit Commit Bot 2017-07-20 15:03:51 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Chris Dumez 2017-07-20 15:45:28 PDT
Reverted r219706 for reason:

Broke iOS build

Committed r219707: <http://trac.webkit.org/changeset/219707>
Comment 11 Chris Dumez 2017-07-20 16:02:20 PDT
Committed r219708: <http://trac.webkit.org/changeset/219708>