Bug 174673
| Summary: | [WPE] Missing keyboard event information breaks fast/events/arrow-keys-on-body.html | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Claudio Saavedra <csaavedra> |
| Component: | WPE WebKit | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Claudio Saavedra
fast/events/arrow-keys-on-body.html fails because key information is missing from the keyboard event created by WPE WebEventFactory.
-BODY - keydown - false,false,false,false - ArrowLeft - ArrowLeft - Left - DOM_KEY_LOCATION_STANDARD - 37 - 0 - 37 - 37
-BODY - keyup - false,false,false,false - ArrowLeft - ArrowLeft - Left - DOM_KEY_LOCATION_STANDARD - 37 - 0 - 37 - 37
+BODY - keydown - false,false,false,false - undefined - undefined - Left - DOM_KEY_LOCATION_STANDARD - 37 - 0 - 37 - 37
+BODY - keyup - false,false,false,false - undefined - undefined - Left - DOM_KEY_LOCATION_STANDARD - 37 - 0 - 37 - 37
The missing properties are event.key and event.code. This seems to be because we're using the default WebKeyboardEvent() constructor that doesn't fill in these properties as other ports do.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Claudio Saavedra
Other affected tests:
webkit.org/b/174673 fast/events/keyboardevent-code.html [ Failure ]
webkit.org/b/174673 fast/events/keyboardevent-key.html [ Failure ]
webkit.org/b/174673 fast/events/key-events-in-input-button.html [ Failure ]
webkit.org/b/174673 fast/events/key-events-in-input-text.html [ Failure ]
webkit.org/b/174673 fast/events/special-key-events-in-input-text.html [ Failure ]
Claudio Saavedra
Seems that the only one still failing here is fast/events/keyboardevent-code.html. The others got fixed recently as the missing bits were added.