Bug 174655

Summary:

AX: Web page reloaded when a node is labelling multiple childnodes

Product:

WebKit

Reporter:

Nan Wang <n_wang>

Component:

Accessibility

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, buildbot, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, n_wang, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	none

Nan Wang

Reported 2017-07-19 10:54:44 PDT

stuck in a loop 298 com.apple.WebCore 0x00007fffb3446745 WebCore::accessibleNameForNode(WebCore::Node*, WebCore::Node*) + 549 299 com.apple.WebCore 0x00007fffb3448b01 WebCore::AccessibilityNodeObject::accessibilityDescriptionForElements(WTF::Vector<WebCore::Element*, 0ul, WTF::CrashOnOverflow, 16ul>&) const + 129 300 com.apple.WebCore 0x00007fffb3448ca3 WebCore::AccessibilityNodeObject::ariaLabeledByAttribute() const + 83 301 com.apple.WebCore 0x00007fffb3446248 WebCore::AccessibilityNodeObject::ariaLabeledByText(WTF::Vector<WebCore::AccessibilityText, 0ul, WTF::CrashOnOverflow, 16ul>&) const + 40 302 com.apple.WebCore 0x00007fffb3445575 WebCore::AccessibilityNodeObject::alternativeText(WTF::Vector<WebCore::AccessibilityText, 0ul, WTF::CrashOnOverflow, 16ul>&) const + 277 303 com.apple.WebCore 0x00007fffb3447ae3 WebCore::AccessibilityNodeObject::textUnderElement(WebCore::AccessibilityTextUnderElementMode) const + 483 304 com.apple.WebCore 0x00007fffb3459b12 WebCore::AccessibilityRenderObject::textUnderElement(WebCore::AccessibilityTextUnderElementMode) const + 770 305 com.apple.WebCore 0x00007fffb3447b2d WebCore::AccessibilityNodeObject::textUnderElement(WebCore::AccessibilityTextUnderElementMode) const + 557 306 com.apple.WebCore 0x00007fffb3459b12 WebCore::AccessibilityRenderObject::textUnderElement(WebCore::AccessibilityTextUnderElementMode) const + 770 307 com.apple.WebCore 0x00007fffb3447b2d WebCore::AccessibilityNodeObject::textUnderElement(WebCore::AccessibilityTextUnderElementMode) const + 557 308 com.apple.WebCore 0x00007fffb3459b12 WebCore::AccessibilityRenderObject::textUnderElement(WebCore::AccessibilityTextUnderElementMode) const + 770 309 com.apple.WebCore 0x00007fffb3446745 WebCore::accessibleNameForNode(WebCore::Node*, WebCore::Node*) + 549 <rdar://problem/32853980>

Attachments
patch (4.56 KB, patch) 2017-07-19 11:04 PDT, Nan Wang	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Nan Wang

Comment 1 2017-07-19 11:04:57 PDT

Created attachment 315939 [details] patch

chris fleizach

Comment 2 2017-07-19 11:27:38 PDT

Comment on attachment 315939 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=315939&action=review > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1738 > + downcast<AccessibilityNodeObject>(*child).ariaLabeledByElements(labeledByElements); is it necessary to do this downcast? isn't ariaLabeledByElements on AXObject?

Nan Wang

Comment 3 2017-07-19 11:32:27 PDT

Comment on attachment 315939 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=315939&action=review >> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1738 >> + downcast<AccessibilityNodeObject>(*child).ariaLabeledByElements(labeledByElements); > > is it necessary to do this downcast? isn't ariaLabeledByElements on AXObject? NO, it's only on AXNodeObject

WebKit Commit Bot

Comment 4 2017-07-19 12:18:44 PDT

Comment on attachment 315939 [details] patch Clearing flags on attachment: 315939 Committed r219661: <http://trac.webkit.org/changeset/219661>

WebKit Commit Bot

Comment 5 2017-07-19 12:18:46 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.