Summary: | [Win] Async image tests are failing. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||
Component: | WebKit Misc. | Assignee: | Per Arne Vollan <pvollan> | ||||
Status: | NEW --- | ||||||
Severity: | Normal | CC: | achristensen, ahmad.saleem792, bfulgham, mjs, sabouhallawa | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 174451 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Per Arne Vollan
2017-07-19 09:43:21 PDT
Created attachment 315925 [details]
Patch
Please hold on this patch. I am renaming the flag because the new name PaintBehaviorAllowAsyncImageDecoding caused too much confusion. I am returning it back to its original name PaintBehaviorSnapshotting and I am adding a new one which is named PaintBehaviorTileFirstPaint. (In reply to Said Abou-Hallawa from comment #2) > Please hold on this patch. I am renaming the flag because the new name > PaintBehaviorAllowAsyncImageDecoding caused too much confusion. I am > returning it back to its original name PaintBehaviorSnapshotting and I am > adding a new one which is named PaintBehaviorTileFirstPaint. Ok, thanks Said! Updated test expectations in <https://trac.webkit.org/changeset/219844/webkit>. Is this patch in the right state now? Can we land it, Said? (In reply to Brent Fulgham from comment #5) > Is this patch in the right state now? Can we land it, Said? No. The enum names have been changed. Please have a look at the changes of <http://trac.webkit.org/changeset/219876> in WebKitLegacy/mac/WebView/WebFrame.mm. Comment on attachment 315925 [details]
Patch
This patch needs to be updated to apply cleanly.
Seems to be AppleWin port related, I think we can mark this as 'RESOLVED CONFIGURATION CHANGED'. |