Summary: | [iOS] REGRESSION: Scrubbing media using built-in controls does not pause media | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||||||
Component: | Media | Assignee: | Antoine Quint <graouts> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Critical | CC: | buildbot, commit-queue, dino, jlewis3, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | iPhone / iPad | ||||||||||||
OS: | iOS 11 | ||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=174682 | ||||||||||||
Attachments: |
|
Description
Antoine Quint
2017-07-19 07:18:05 PDT
Created attachment 315920 [details]
Patch
Comment on attachment 315920 [details] Patch Attachment 315920 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4148350 New failing tests: media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag.html Created attachment 315926 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Created attachment 315927 [details]
Patch
Comment on attachment 315927 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315927&action=review > Source/WebCore/Modules/modern-media-controls/controls/slider.js:192 > + // so the value shoudl be read back from it dynamically. typo Created attachment 315948 [details]
Patch for landing
Comment on attachment 315948 [details] Patch for landing Clearing flags on attachment: 315948 Committed r219662: <http://trac.webkit.org/changeset/219662> All reviewed patches have been landed. Closing bug. The test added with this patch: media/modern-media-controls/scrubber-support/scrubber-support-drag.html is extremely flaky and fails most of the time according to the dashboard. https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fscrubber-support%2Fscrubber-support-drag.html https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r219683%20(2215)/results.html Diff: --- /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/media/modern-media-controls/scrubber-support/scrubber-support-drag-expected.txt +++ /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/media/modern-media-controls/scrubber-support/scrubber-support-drag-actual.txt @@ -4,7 +4,7 @@ PASS media.currentTime is within 0.2 of 3.0136 -PASS media.currentTime is 0 +FAIL media.currentTime should be 0. Was 3.1872. PASS successfullyParsed is true TEST COMPLETE Flaky test followup is at https://bugs.webkit.org/show_bug.cgi?id=174682. |