Summary: | Release assert when using paper-textarea due to autocorrect IDL attribute missing CEReactions | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Marc Bornträger <marc.borntraeger> | ||||||
Component: | Bindings | Assignee: | Ryosuke Niwa <rniwa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Blocker | CC: | cdumez, esprehn+autocc, ews-watchlist, gyuyoung.kim, koivisto, kondapallykalyan, marc.borntraeger, paulus, rniwa, simon.fraser, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Safari 10 | ||||||||
Hardware: | iPhone / iPad | ||||||||
OS: | iOS 10.3 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 154907 | ||||||||
Attachments: |
|
Description
Marc Bornträger
2017-07-18 08:06:33 PDT
You'll have to give us an actual test app for us to be able to debug this. Thanks for the reply @Simon Fraser. I have included two test apps: One for the web frontend and one for the WKWebView app. With these two projects it should be perfectly reproducible. Do you need anything else? With "included" I mean I have published the code on GitHub and posted the URL in the description. Not as attachment in the comments. Sorry, I missed that you had github example (there are a lot of words in the report). Just trying to give an accurate report :) FYI: if you wrap the component with all attributes, it still does not work. The property `autocorrect` seems to be causing the problem. Only if you remove that one property in the wrapped component it seems to work. (you don't even need to use the attribute in your element. It's already enough to provoke the crash if `autocorrect` is defined as an attribute) That exception will be thrown if you're trying to add an attribute inside your custom element's constructor per specification. Could you create a simple HTML file which reproduces the issue inside a WKWebView? I really can't follow various instructions and comments you've posted. sure. It can be hard to read as this website does not allow formatting. For a easier read I have also published the issue here: https://github.com/PolymerElements/paper-input/issues/556 Regarding the HTML file: You can take the HTML content from this site: https://raw-dot-custom-elements.appspot.com/PolymerElements/paper-input/v2.0.0/paper-input/demo/index.html Unfortunately it's not very easy to publish a single HTML file as I don't really know where the issue is. So we need to define couple of dependencies like Polymer, etc. to reproduce it. But I hope the URL above helps a bit. It can be reproduced with the following HTML snippet: <script type='module'> import 'https://unpkg.com/@polymer/paper-input@3.0.0-pre.21/paper-textarea.js?module'; document.createElement('paper-textarea'); </script> Also published as CodePen: https://codepen.io/anon/pen/ejwMNN Created attachment 350499 [details]
Reduction
Huh, this causes a crash in MobileSafari on iOS 12 simulator...
Wow, it still crashes on trunk. This is because "autocorrect" IDL attribute on HTML element is missing CEReactions. Created attachment 350507 [details]
Fixes the bug
Thank you! Comment on attachment 350507 [details] Fixes the bug Clearing flags on attachment: 350507 Committed r236439: <https://trac.webkit.org/changeset/236439> All reviewed patches have been landed. Closing bug. |