Bug 174627

Summary: [iOS] WebKit media controls are sometimes shown after exiting full screen on vimeo.com
Product: WebKit Reporter: Antoine Quint <graouts>
Component: MediaAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, jeremyj-wk, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: iOS 11   
See Also: https://bugs.webkit.org/show_bug.cgi?id=174626
Attachments:
Description Flags
Patch
none
Patch for landing none

Antoine Quint
Reported 2017-07-18 07:16:15 PDT
Steps to reproduce: 1. go to https://vimeo.com/225249697 2. tap to start the video 3. enter fullscreen 4. exit fullscreen by tapping the X icon Both the WebKit media controls and the Vimeo custom controls appear sometimes, but not always. This is due to https://bugs.webkit.org/show_bug.cgi?id=174626, where the "webkitfullscreenchange" event isn't fired when entering or exiting fullscreen, so depending on when the "play" or "pause" event fires, the ControlsVisibilitySupport object may think that the controls are still in fullscreen and not get an event that we exited fullscreen.
Attachments
Patch (6.03 KB, patch)
2017-07-18 07:44 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.07 KB, patch)
2017-07-18 12:21 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2017-07-18 07:20:51 PDT
<rdar://problem/33301005>
Antoine Quint
Comment 2 2017-07-18 07:44:20 PDT
Created attachment 315794 [details] Patch
Jeremy Jones
Comment 3 2017-07-18 11:37:09 PDT
Comment on attachment 315794 [details] Patch LGTM
Jeremy Jones
Comment 4 2017-07-18 11:44:25 PDT
Comment on attachment 315794 [details] Patch provisional r+
Antoine Quint
Comment 5 2017-07-18 12:21:34 PDT
Created attachment 315814 [details] Patch for landing
WebKit Commit Bot
Comment 6 2017-07-18 12:59:17 PDT
Comment on attachment 315814 [details] Patch for landing Clearing flags on attachment: 315814 Committed r219621: <http://trac.webkit.org/changeset/219621>
WebKit Commit Bot
Comment 7 2017-07-18 12:59:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.