Bug 174610

Summary: Update layout test fast/forms/content-with-margins-inside-button.html to work when button has a default color
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>
Status: RESOLVED FIXED    
Severity: Minor CC: bugs-noreply, commit-queue, darin, Ms2ger
Priority: P5    
Version: Other   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2017-07-17 21:58:49 PDT
Layout test fast/forms/content-with-margins-inside-button.html is failing for GTK since, most likely, r217674 ("[GTK] Bump GTK+ and its dependencies in jhbuild"). However it cannot be simply rebaselined since it is a reftest. The text color inside the button no longer matches. Updating expectations accordingly.
Attachments
Patch (3.58 KB, patch)
2017-08-01 03:03 PDT, Ms2ger (he/him; ⌚ UTC+1/+2) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 1 2017-08-01 03:03:35 PDT
Created attachment 316838 [details] Patch
Darin Adler
Comment 2 2017-08-01 08:49:47 PDT
I don’t wish to be pedantic, but I believe that a bug like this one should not have the [GTK] prefix. We try to use those prefixes for changes that are truly specific to a particular port, changes that can’t possibly affect other ports, as opposed to patches that are motivated by a problem that shows only on one port, but are changes to cross-platform code.
WebKit Commit Bot
Comment 3 2017-08-01 09:42:21 PDT
Comment on attachment 316838 [details] Patch Clearing flags on attachment: 316838 Committed r220104: <http://trac.webkit.org/changeset/220104>
WebKit Commit Bot
Comment 4 2017-08-01 09:42:23 PDT
All reviewed patches have been landed. Closing bug.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 5 2017-08-02 04:57:17 PDT
(In reply to Darin Adler from comment #2) > I don’t wish to be pedantic, but I believe that a bug like this one should > not have the [GTK] prefix. We try to use those prefixes for changes that are > truly specific to a particular port, changes that can’t possibly affect > other ports, as opposed to patches that are motivated by a problem that > shows only on one port, but are changes to cross-platform code. Agreed; changed the summary to match what I did.
Note You need to log in before you can comment on or make changes to this bug.