Bug 174600

Summary: [cmake] Set library types before their targets are created
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: Tools / TestsAssignee: Konstantin Tokarev <annulen>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, Hironori.Fujii, lforschler, mcatanzaro
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Konstantin Tokarev 2017-07-17 16:54:04 PDT
Since r219560 library targets are created before PlatformXXX.cmake files are processed, however library type must be passed in add_library() call and cannot be changed afterwards. Set these variables in OptionsXXX.cmake.
Comment 1 Konstantin Tokarev 2017-07-17 16:58:45 PDT
Created attachment 315731 [details]
Patch
Comment 2 Konstantin Tokarev 2017-07-17 17:31:59 PDT
Created attachment 315738 [details]
Patch
Comment 3 WebKit Commit Bot 2017-07-17 22:46:59 PDT
Comment on attachment 315738 [details]
Patch

Clearing flags on attachment: 315738

Committed r219602: <http://trac.webkit.org/changeset/219602>
Comment 4 WebKit Commit Bot 2017-07-17 22:47:00 PDT
All reviewed patches have been landed.  Closing bug.