Bug 174571

Summary: Dismissing the captions panel using the mouse is too eager to remove the captions panel and media controls
Product: WebKit Reporter: Antoine Quint <graouts>
Component: MediaAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, eric.carlson, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews125 for ios-simulator-wk2 none

Antoine Quint
Reported 2017-07-16 14:40:18 PDT
When the captions panel is up, clicking should: - dismiss the panel if the click is outside of the panel - dismiss the panel and the media controls if the click is outside the video and the media controls have auto-hide on (ie. media is playing) - dismiss the panel and the media controls after the track selection animation is finished if a track is selected Right now we: - dismiss the panel immediately if the click is anywhere inside the captions panel - dismiss the media controls always, even when the media is paused
Attachments
Patch (17.16 KB, patch)
2017-07-16 15:31 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (995.44 KB, application/zip)
2017-07-16 16:57 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2017-07-16 14:40:38 PDT
<rdar://problem/33294968>
Antoine Quint
Comment 2 2017-07-16 15:31:44 PDT
Created attachment 315629 [details] Patch
Build Bot
Comment 3 2017-07-16 16:57:36 PDT
Comment on attachment 315629 [details] Patch Attachment 315629 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4132666 New failing tests: imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html http/tests/canvas/canvas-tainted-after-draw-image.html
Build Bot
Comment 4 2017-07-16 16:57:37 PDT
Created attachment 315635 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
WebKit Commit Bot
Comment 5 2017-07-16 22:29:24 PDT
Comment on attachment 315629 [details] Patch Clearing flags on attachment: 315629 Committed r219552: <http://trac.webkit.org/changeset/219552>
WebKit Commit Bot
Comment 6 2017-07-16 22:29:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.