Bug 174571 – Dismissing the captions panel using the mouse is too eager to remove the captions panel and media controls

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Antoine Quint]

When the captions panel is up, clicking should:

  - dismiss the panel if the click is outside of the panel
  - dismiss the panel and the media controls if the click is outside the video and the media controls have auto-hide on (ie. media is playing)
  - dismiss the panel and the media controls after the track selection animation is finished if a track is selected

Right now we:

  - dismiss the panel immediately if the click is anywhere inside the captions panel
  - dismiss the media controls always, even when the media is paused

[Antoine Quint]

<rdar://problem/33294968>

[Antoine Quint]

Created attachment 315629 [details]
Patch

[Build Bot]

Comment on attachment 315629 [details]
Patch

Attachment 315629 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4132666

New failing tests:
imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html
http/tests/canvas/canvas-tainted-after-draw-image.html

[Build Bot]

Created attachment 315635 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[WebKit Commit Bot]

Comment on attachment 315629 [details]
Patch

Clearing flags on attachment: 315629

Committed r219552: <http://trac.webkit.org/changeset/219552>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.