Bug 174555

Summary: Implement FALLTHROUGH attribute for C with GCC
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: Web Template FrameworkAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, cdumez, cmarcelo, commit-queue, darin, dbates, mcatanzaro
Priority: P2    
Version: Other   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Michael Catanzaro 2017-07-15 20:01:16 PDT 
My attempt to silence the JSC -Wimplicit-fallthrough warnings in bug #174463 failed because they are coming from a C file, and our FALLTHROUGH macro is only implemented for C++. This is only possible to do for GCC, because Clang only supports this attribute using the [[C++ attribute syntax]].
Comment 1 Michael Catanzaro 2017-07-15 20:15:41 PDT 
Created attachment 315581 [details]
Patch
Comment 2 Michael Catanzaro 2017-07-23 07:49:28 PDT 
Created attachment 316228 [details]
Patch
Comment 3 WebKit Commit Bot 2017-07-23 14:01:31 PDT 
Comment on attachment 316228 [details]
Patch

Clearing flags on attachment: 316228

Committed r219791: <http://trac.webkit.org/changeset/219791>
Comment 4 WebKit Commit Bot 2017-07-23 14:01:33 PDT 
All reviewed patches have been landed.  Closing bug.