Bug 174545

Summary: [CMake] Raise minimum CMake requirement
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bugs-noreply, commit-queue, fujii.hironori, mcatanzaro
Priority: P2    
Version: Other   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2017-07-15 10:14:19 PDT
We can raise our CMake required version now, and remove some old code.
Attachments
Patch (6.88 KB, patch)
2017-07-15 20:53 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2017-07-15 13:33:23 PDT
FWIW, raising requirement to 3.1 would allow us to use target_sources command, that can enable us to make target-specific setup in PlatformXXX.cmake files (now all such code has to be in shared CMakeLists.txt files)
Michael Catanzaro
Comment 2 2017-07-15 20:49:18 PDT
We can go as high as 3.5 (Ubuntu 16.04). Let's stick with 3.3 for now, though. That was the version I was planning to upgrade to to get access to a new generator expression. Turns out I won't be using it after all... but it's also the minimum version needed to remove all of our CMake version conditionals. So why not? Using target_sources will be a great next step. Note this will break our Debian stable bot, but that's due to be upgraded to Stretch anyway.
Michael Catanzaro
Comment 3 2017-07-15 20:53:02 PDT
Created attachment 315586 [details] Patch
WebKit Commit Bot
Comment 4 2017-07-16 07:28:16 PDT
Comment on attachment 315586 [details] Patch Clearing flags on attachment: 315586 Committed r219547: <http://trac.webkit.org/changeset/219547>
WebKit Commit Bot
Comment 5 2017-07-16 07:28:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.