Summary: | [GTK] Sort inspector GResource manifest to ensure reproducible builds | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Bernhard M. Wiedemann <webkitbmw> | ||||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aperez, bugs-noreply, clopez, commit-queue, mcatanzaro, zan | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Bernhard M. Wiedemann
2017-07-15 01:13:24 PDT
Created attachment 315536 [details]
fixing patch
Comment on attachment 315536 [details]
fixing patch
Informal review: I would r+ this without doubt.
Also: Having reproducible builds is IMHO a noble goal, so we should
help from our side merging patches upstream whenever possible :-)
Bernhard: I have CC'd a few people to try and get the patch landed. If you used “webkit-patch upload”, a one nice tip for next time is passing “--suggest-reviewers --request-commit” to it, which will get reviewers CC'd automatically, and ask the automated commit-queue to land your patch. And many thanks for posting the patch! Thanks. It also needs a ChangeLog entry ('Tools/Scripts/prepare-ChangeLog -b 174540') Also note that Fedora and Debian have both removed their old/insecure webkitgtk3 packages. Now would be a good time for openSUSE to follow suit. Created attachment 315565 [details]
patch with changelog entry
Sorry, I forgot to change the title... please change the title in the ChangeLog, then we can land this. Created attachment 315594 [details]
patch with updated changelog entry
The commit-queue encountered the following flaky tests while processing attachment 315594 [details]: storage/indexeddb/modern/new-database-after-user-delete.html bug 174354 (author: beidson@apple.com) The commit-queue is continuing to process your patch. The commit-queue encountered the following flaky tests while processing attachment 315594 [details]:
The commit-queue is continuing to process your patch.
Comment on attachment 315594 [details] patch with updated changelog entry Clearing flags on attachment: 315594 Committed r219546: <http://trac.webkit.org/changeset/219546> All reviewed patches have been landed. Closing bug. |