Bug 174540

Summary: [GTK] Sort inspector GResource manifest to ensure reproducible builds
Product: WebKit Reporter: Bernhard M. Wiedemann <webkitbmw>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply, clopez, commit-queue, mcatanzaro, zan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
fixing patch
none
patch with changelog entry
none
patch with updated changelog entry none

Bernhard M. Wiedemann
Reported 2017-07-15 01:13:24 PDT
When building the webkitgtk3 package for openSUSE, it produces random variations in the resulting libwebkitgtk-3.0.so.0.22.17 because GResourceBundle.xml is generated via python's glob.glob function that returns entries in undeterministic filesystem order.
Attachments
fixing patch (1.17 KB, patch)
2017-07-15 01:15 PDT, Bernhard M. Wiedemann 		no flags
DetailsFormatted DiffDiff
patch with changelog entry (1.08 KB, patch)
2017-07-15 13:15 PDT, Bernhard M. Wiedemann 		no flags
DetailsFormatted DiffDiff
patch with updated changelog entry (1.10 KB, patch)
2017-07-15 22:24 PDT, Bernhard M. Wiedemann 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Bernhard M. Wiedemann
Comment 1 2017-07-15 01:15:32 PDT
Created attachment 315536 [details] fixing patch
Adrian Perez
Comment 2 2017-07-15 03:35:37 PDT
Comment on attachment 315536 [details] fixing patch Informal review: I would r+ this without doubt. Also: Having reproducible builds is IMHO a noble goal, so we should help from our side merging patches upstream whenever possible :-)
Adrian Perez
Comment 3 2017-07-15 03:39:15 PDT
Bernhard: I have CC'd a few people to try and get the patch landed. If you used “webkit-patch upload”, a one nice tip for next time is passing “--suggest-reviewers --request-commit” to it, which will get reviewers CC'd automatically, and ask the automated commit-queue to land your patch. And many thanks for posting the patch!
Michael Catanzaro
Comment 4 2017-07-15 08:07:18 PDT
Thanks. It also needs a ChangeLog entry ('Tools/Scripts/prepare-ChangeLog -b 174540')
Michael Catanzaro
Comment 5 2017-07-15 08:07:59 PDT
Also note that Fedora and Debian have both removed their old/insecure webkitgtk3 packages. Now would be a good time for openSUSE to follow suit.
Bernhard M. Wiedemann
Comment 6 2017-07-15 13:15:10 PDT
Created attachment 315565 [details] patch with changelog entry
Michael Catanzaro
Comment 7 2017-07-15 15:33:49 PDT
Sorry, I forgot to change the title... please change the title in the ChangeLog, then we can land this.
Bernhard M. Wiedemann
Comment 8 2017-07-15 22:24:29 PDT
Created attachment 315594 [details] patch with updated changelog entry
WebKit Commit Bot
Comment 9 2017-07-16 05:07:31 PDT
The commit-queue encountered the following flaky tests while processing attachment 315594 [details]: storage/indexeddb/modern/new-database-after-user-delete.html bug 174354 (author: beidson@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 10 2017-07-16 05:07:32 PDT
The commit-queue encountered the following flaky tests while processing attachment 315594 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 11 2017-07-16 05:51:30 PDT
Comment on attachment 315594 [details] patch with updated changelog entry Clearing flags on attachment: 315594 Committed r219546: <http://trac.webkit.org/changeset/219546>
WebKit Commit Bot
Comment 12 2017-07-16 05:51:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.