Bug 174536

Summary: line-height: <number> gets visually applied twice when text autosizing is in effect
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, dino, jonlee, mitz, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 174406    
Attachments:
Description Flags
Patch
simon.fraser: review+, commit-queue: commit-queue-
Archive of layout-test-results from ews125 for ios-simulator-wk2 none

Myles C. Maxfield
Reported 2017-07-14 21:32:58 PDT
line-height: <number> gets visually applied twice when text autosizing is in effect
Attachments
Patch (5.37 KB, patch)
2017-07-14 21:39 PDT, Myles C. Maxfield 		simon.fraser: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (11.24 MB, application/zip)
2017-07-15 01:21 PDT, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2017-07-14 21:39:03 PDT
Created attachment 315530 [details] Patch
Build Bot
Comment 2 2017-07-15 01:20:59 PDT
Comment on attachment 315530 [details] Patch Attachment 315530 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4124119 New failing tests: imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html
Build Bot
Comment 3 2017-07-15 01:21:00 PDT
Created attachment 315538 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Myles C. Maxfield
Comment 4 2017-07-15 09:36:51 PDT
Failure is unrelated.
Simon Fraser (smfr)
Comment 5 2017-07-15 14:37:28 PDT
Comment on attachment 315530 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315530&action=review > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=174536 You should probably make a radar for this too.
Radar WebKit Bug Importer
Comment 6 2017-07-15 22:42:51 PDT
<rdar://problem/33338259>
WebKit Commit Bot
Comment 7 2017-07-15 22:43:22 PDT
Comment on attachment 315530 [details] Patch Rejecting attachment 315530 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 315530, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: Hunk #1 FAILED at 1440. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/css/StyleBuilderConverter.h.rej patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/fast/text-autosizing/line-height-number-expected.html patching file LayoutTests/fast/text-autosizing/line-height-number.html Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Simon Fraser']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/4129110
Myles C. Maxfield
Comment 8 2017-07-15 22:52:46 PDT
Committed r219543: <http://trac.webkit.org/changeset/219543>
Note You need to log in before you can comment on or make changes to this bug.